Repository navigation
feat(tempo): sync configurable accounts with Tempo main (0.x) - #519
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB (cherry picked from commit b126168)
Rename the configurable account hash domains to tempo:configurable-account:* (tempoxyz/tempo#8502) and pin Tempo's Rust vectors in tests. Add AccountConfig.fromUpgrade for TIP-1113 in-place migration, reject admin key authorizations signed by configurable accounts (TIP-1137), and stop passing empty or 3-byte simulation keyData the node rejects. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB (cherry picked from commit f52be77)
Point the e2e at the image built from tempoxyz/tempo#8486, rename the genesis key to configurableAccountRecoveryFactory, and activate T14. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB (cherry picked from commit cf0b920)
The node binds a root-signed grant to its signer and only requires `account` on admin-signed grants (TIP-1049), so ox rejected valid grants. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB (cherry picked from commit 88a0e8d)
0.x also required `account` for configurable grants at the type level, in `KeyAuthorization.Input` and `KeyAuthorization.Rpc`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
jxom
marked this pull request as ready for review
October 20, 2026 23:05
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
Red checks on this head (
The browser job is green with the Generated by Claude Code |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d6a754939
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Configurable key types only exist from T14, where TIP-1137 rejects every admin grant, so an isAdmin grant of a configurable key is always invalid, whoever signs it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB (cherry picked from commit 121d138)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB
snario
added a commit
to tempoxyz/docs
that referenced
this pull request
Oct 21, 2026
…#1047) * feat(accounts): point the Accounts demos at the t14-checkpoint devnet The t14-checkpoint devnet runs joshie/configurable-t14-devnet-checkpoint, which renames the configurable account hash domains and RPC fields. - Repoint the RPC proxy, tailnet URL and Node snippet from multisig-1113. - Pin viem's ox to the wevm/ox#519 preview for the new hash domains. - Rename multisigSimulation to configurableAccountSimulation in the proxy, so the node estimates a new account's first transaction correctly. Configuration updates still fail until viem ships the renamed precompile ABI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(accounts): parse the renamed config update event and upgrade salt domain The t14-checkpoint node emits ConfigurableAccountConfigUpdated and salts in-place upgrades with tempo:configurable-account:upgrade. viem still expects MultisigConfigUpdated, so updateConfigSync threw after a successful update. Send the update directly and parse the new event. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(deps): scope the ox preview override to the docs' viem viem>ox also replaced ox under transitive viem 2.54.6, which imports the MultisigConfig export the preview dropped, and broke the build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Match tempoxyz/tempo joshie/configurable-t14-devnet-checkpoint: the RPC key type is configurableAccount and the request field is configurableAccountSimulation, the simulation spec carries an optional grant signer, and configurable accounts may be or authorize admin keys, so the TIP-1137 guard is removed. The e2e runs against image sha-04e67d3. (cherry picked from commit e7be197) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB
Merged
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #518 to
0.x, for the viem release line (ox@0.14.x).Same changes, synced with tempoxyz/tempo
joshie/configurable-t14-devnet-checkpoint:tempo:configurable-account:*hash domains, pinned to Tempo's Rust vectors.configurableAccountandconfigurableAccountSimulation, plus the optional simulationsigner.AccountConfig.fromUpgrade(TIP-1113).keyDatafix.ghcr.io/tempoxyz/tempo:sha-04e67d3.ubuntu-24.04.Differences from main:
0.xhas no zod tempo modules orAGENTS.md, so those parts are dropped.0.xalso requiredaccountfor configurable grants at the type level (theKeyAuthorization.InputandKeyAuthorization.Rpcunions), soaccountis now optional in both.🤖 Generated with Claude Code
https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB