Repository navigation
feat(tempo): sync configurable accounts with Tempo main - #518
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB
Rename the configurable account hash domains to tempo:configurable-account:* (tempoxyz/tempo#8502) and pin Tempo's Rust vectors in tests. Add AccountConfig.fromUpgrade for TIP-1113 in-place migration, reject admin key authorizations signed by configurable accounts (TIP-1137), and stop passing empty or 3-byte simulation keyData the node rejects. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB
Point the e2e at the image built from tempoxyz/tempo#8486, rename the genesis key to configurableAccountRecoveryFactory, and activate T14. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB
The node binds a root-signed grant to its signer and only requires `account` on admin-signed grants (TIP-1049), so ox rejected valid grants. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
|
Two red checks, neither from this diff:
Generated by Claude Code |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8051c5f29d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Vercel (docs deploy) is red on this PR and on #519, and it failed the same way on #516 on Oct 13, so it isn't specific to this diff. A clean local Generated by Claude Code |
The core KeyAuthorization conversions already reject them (TIP-1137); the Rpc, Domain and DomainToRpc schemas now enforce the same invariant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB
Configurable key types only exist from T14, where TIP-1137 rejects every admin grant, so an isAdmin grant of a configurable key is always invalid, whoever signs it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB
Match tempoxyz/tempo joshie/configurable-t14-devnet-checkpoint: the RPC key type is configurableAccount and the request field is configurableAccountSimulation, the simulation spec carries an optional grant signer, and configurable accounts may be or authorize admin keys, so the TIP-1137 guard is removed. The e2e runs against image sha-04e67d3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB
Brings
ox/tempoconfigurable accounts in line with tempoxyz/tempojoshie/configurable-t14-devnet-checkpoint(the #7577–#7581 stack on main, after tempoxyz/tempo#8502) and the TIP cluster in tempoxyz/tempo#7510.tempo:multisig:*→tempo:configurable-account:*. EveryAccountConfig.getAddress,getCommitmentandgetSignPayloadresult changes. A new test pins Tempo's Rust vectors (crates/primitives/tests/configurable_account.rs), and ox matches them byte for byte.multisig→configurableAccount, andTransactionRequest.multisigSimulation→configurableAccountSimulation.AccountSimulationgains the optional grantsigner.AccountConfig.fromUpgrade(account, { owners, threshold }), the version-1 configupgradeAccountinstalls (salt = keccak256("tempo:configurable-account:upgrade" || account)).account. The node only requires it on admin-signed grants (TIP-1049).MissingAccountErroris kept but deprecated.keyDataare shimmed to a 2-byte length hint, because the node only accepts 1-, 2- or 4-byte hints.ghcr.io/tempoxyz/tempo:sha-04e67d3(the devnet checkpoint plus a recovery-factory genesis option) with T14 and theconfigurableAccountRecoveryFactorygenesis key.ubuntu-24.04, because Playwright 1.58.2 doesn't support the Ubuntu 26.04 thatubuntu-latestnow resolves to.Notes:
pnpm docs:buildpasses locally..agents/plans/configurable-accounts-tempo-sync.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01UUGrLTHJy3Rheqc2GoFoTB