Repository navigation
Conversation
|
From Telco: This removes NXxas from application definitions which requires a vote and adds new content to contributed definitions, which doesn't require a vote. To me that means this should be split into two PRs, one removing old content and one adding new content to contributed definitions. Also your comment mentions removing NXxasproc, but I don't see that in this pull request? Out of curiosity, how close is this to being fully ready for adoption in the community? Finally, just verifying that the old NXxas is fully unused, so greatly changing its meaning won't affect a huge of amount of users/data, correct? |
964f7e0 to
ad5cb71
Compare
|
@phyy-nx Thank you for the feedback. I separated the removal of the existing The current MR builds on this and on a second commit #1619 that introduces a few base classes, like All the new classes land in the contributed definitions. Regarding adoption by the community, this will certainly take some time. However, during our meeting in July, we received full support from the chairs of the International X-ray Absorption Society (IXAS) and the IUCr commission on XAS. Additionally, following feedback from scientists doing quick XAS acquisitions at the same meeting, the new definitions were updated to allow multiple spectra to be stored. |
This reverts commit 72d12a7.
|
@phyy-nx From what I understood from @woutdenolf the current What is the procedure to make changes to a field like The old NXxas requires the energy dataset under |
706903c to
27fd7e0
Compare
|
@mretegan I've addressed some of the comments, but I think some of the others are beyond me. |
The MR introduces a subset of the X-ray absorption application definitions that use the inheritance-based mechanism discussed in #1352 and XraySpectroscopy#7. Once validated, new MRs will be opened for the remaining classes, which are somewhat more complex.
The new/updated application definitions are:
NXxasis a generic application definition for X-ray absorption spectroscopy (XAS).NXxas_transis an application definition that specializesNXxasfor data acquired in transmission mode.The new classes will replace the current
NXxasandNXxasproc, as each of them is designed to hold both raw and processed data, i.e., no need to have separate definitions.One particularly is the use of
dataRankto allow for either 1D or 2D data. Currently this is only expressed in thedocof different fields, but @woutdenolf had a few suggestions on how this could also be validated (see XraySpectroscopy#7 (comment)).