Repository navigation
ffmpegServer: ffmpegStream ENABLED, default 1 - #260
Merged
Merged
Conversation
ffmpegStream passes ENABLED to ffmpegStream.template, defaulting to 1 as the DLS builder's ffmpegStream does. NDPluginBase.template defaults ENABLED to 0, which starts every MJPEG stream with EnableCallbacks 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uybqz5aF58yDAtjf9GDXBd
|
Warning Review limit reachedThis review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Next included review available in 8 minutes. View limit details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
ffmpegServer.ffmpegStreamgains anENABLEDparameter (int, default 1) and passes it toffmpegStream.template.The DLS builder's
ffmpegStreamhasENABLED = 1("Plugin Enabled at startup?"), so builder IOCs start their MJPEG streams withEnableCallbacks= 1. The ibek model had no such parameter, soNDPluginBase.template's$(ENABLED=0)applied and every converted IOC started its streams disabled. Found on BL08J-DI-IOC-01 (ioc-adaravis, 11 MJPEG streams) in a db comparison between the builder IOC and its conversion.The name, type, default and description match the builder's exactly, so builder2ibek can pass the XML attribute straight through (follow-up PR in builder2ibek).
How tested
ibek ioc generate-schema */*.ibek.support.yaml --no-ibek-defs(thecheck-generatejob) passes with ibek 4.12.1.ffmpegStream.templateat the pinned SHA includesNDPluginBase.template, whereEnableCallbacks(abo) takesVALfrom$(ENABLED=0).ibek runtime generateon a two-stream test ioc.yaml givesENABLED=1for the default and0when set; st.cmd unchanged.:MJPG:EnableCallbacksdifferences against the builder IOC's database.Found in review
Nothing in this change. A fresh review pointed out the builder2ibek converter still drops
ENABLEDforffmpegStream; that is fixed in the follow-up PR.Not handled
EnableCallbacksis autosaved, so a restored value overridesENABLEDin IOCs that autosave. Builder IOCs behave the same.🤖 Generated with Claude Code
https://claude.ai/code/session_01Uybqz4Bmh42ZmYjTGZ2KWN