Skip to content

ffmpegServer: ffmpegStream ENABLED, default 1 - #260

Merged
gilesknap merged 1 commit into
mainfrom
ffmpegstream-enabled
Nov 20, 2026
Merged

gilesknap merged 1 commit into
mainfrom
ffmpegstream-enabled

Conversation

@gilesknap

Copy link
Copy Markdown
Member

What and why

ffmpegServer.ffmpegStream gains an ENABLED parameter (int, default 1) and passes it to ffmpegStream.template.

The DLS builder's ffmpegStream has ENABLED = 1 ("Plugin Enabled at startup?"), so builder IOCs start their MJPEG streams with EnableCallbacks = 1. The ibek model had no such parameter, so NDPluginBase.template's $(ENABLED=0) applied and every converted IOC started its streams disabled. Found on BL08J-DI-IOC-01 (ioc-adaravis, 11 MJPEG streams) in a db comparison between the builder IOC and its conversion.

The name, type, default and description match the builder's exactly, so builder2ibek can pass the XML attribute straight through (follow-up PR in builder2ibek).

How tested

  • ibek ioc generate-schema */*.ibek.support.yaml --no-ibek-defs (the check-generate job) passes with ibek 4.12.1.
  • Checked that ffmpegStream.template at the pinned SHA includes NDPluginBase.template, where EnableCallbacks (a bo) takes VAL from $(ENABLED=0).
  • ibek runtime generate on a two-stream test ioc.yaml gives ENABLED=1 for the default and 0 when set; st.cmd unchanged.
  • The same edit overlaid on the BL08J-DI-IOC-01 image removed all 11 :MJPG:EnableCallbacks differences against the builder IOC's database.
  • builder2ibek's test suite and samples run against this commit in the follow-up PR.

Found in review

Nothing in this change. A fresh review pointed out the builder2ibek converter still drops ENABLED for ffmpegStream; that is fixed in the follow-up PR.

Not handled

  • EnableCallbacks is autosaved, so a restored value overrides ENABLED in IOCs that autosave. Builder IOCs behave the same.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Uybqz4Bmh42ZmYjTGZ2KWN

ffmpegStream passes ENABLED to ffmpegStream.template, defaulting to 1 as
the DLS builder's ffmpegStream does. NDPluginBase.template defaults
ENABLED to 0, which starts every MJPEG stream with EnableCallbacks 0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Uybqz5aF58yDAtjf9GDXBd
@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2974cd7c-1c3f-43e8-9dfd-017ff9616780
Commits

Reviewing files that changed from the base of the PR and between b52909b and e545d7b.

Files selected for processing: 1

  • ffmpegServer/ffmpegServer.ibek.support.yaml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant