Repository navigation
Conversation
copier update from 5.1.1 to 5.1.4:
- .devcontainer/postCreateCommand runs 'make clean uninstall' in
/epics/ioc instead of removing the build products by hand
- .devcontainer/initializeCommand no longer looks for containers made
from another image ('ibek dev' still warns about them)
- build and initializeCommand init the submodule when ibek-support/.git
is missing
- README describes the above
- requirements.txt requires ibek>=4.12.0
requirements.txt raises that floor to ibek>=4.12.1: builder2ibek emits
post_db_files in ioc.yaml, which ibek 4.11.1 rejects.
ibek-support e33e7be -> b79a71e (branch pmac-geobrick-axis-status):
PMAC and GeoBrick load pmacStatusAxis.template for each axis, as
PowerPMAC does. Also brings iocStats loading iocAdminScanMon.db with
iocAdminSoft only on RTEMS. The pin moves to ibek-support main once that
change merges.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Uybqz4Bmh42ZmYjTGZ2KWN
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
Moves the ibek-support pin from the head of ibek-support#259 (b79a71e) to main, which now holds #259's merge and #260 (ffmpegServer ffmpegStream ENABLED, a module this image does not build). The pmac support YAML is identical to the previous pin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uybqz4Bmh42ZmYjTGZ2KWN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
postCreateCommandrunsmake clean uninstallin/epics/ioc.initializeCommanddrops its stale-container scan;ibek devstill warns about a stale container.buildandinitializeCommandinit the submodule whenibek-support/.gitis missing.requirements.txt; the template pins >= 4.12.0). builder2ibek now emitspost_db_filesin ioc.yaml, and ibek 4.11.1, which is in 2-7-10ec2, rejects it. The BL08J-MO-IOC-01/02/03 conversions failgenerateon the current release because of this. The Dockerfile'suv pip install --upgrade -r requirements.txtenforces the floor.pmacStatusAxis.templateper axis, as PowerPMAC already does. The pin also brings ffmpegServer: ffmpegStream ENABLED, default 1 ibek-support#260 (ffmpegServer only, not built here) and the iocStats change, which loadsiocAdminScanMon.dbwithiocAdminSoftonly on RTEMS.Before release
Draft on purpose: generic IOC releases are held for one rebuild round. The ibek-support pin is on ibek-support main, so epics-containers/ioc-template#100 no longer blocks a release.
How tested
tests/run-tests.shwas not run locally; this PR's CI runs it.ibek runtime generate2 --no-pviwith ibek 4.12.1 and the support YAMLs this image copies (pmac YAML at b79a71e, identical at e1c7145) on the five converted BL08J MO pmac configs (01/02/03/06/07). All five generate, includingpost_db_files, and each gets apmacStatusAxisrow per axis.Found in review
A fresh review found the copier update identical to the rendered 5.1.4 template, with ioc-pmac's customisations untouched. It also confirmed the ibek floor is enforced by the Dockerfile. It found nothing to fix. It pointed out that the pinned commit had to be pushed first, which has been done.
A second fresh review of the pin move to e1c7145 found it clean: the only content change from b79a71e is ffmpegServer, which this image does not copy.
Not handled
🤖 Generated with Claude Code
https://claude.ai/code/session_01Uybqz4Bmh42ZmYjTGZ2KWN