Repository navigation
Conversation
Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the existing LCAO
nspin=4Mulliken integration test to validate nonzeroMx,My, andMzcomponents.The previous test initialized magnetic moments along ±x, resulting in nearly zero
My. Consequently, the test could not detect the incorrectMysign fixed in #8250.Changes
scf_out_mul_spin4test.mulliken.txt.refusing the corrected ABACUS output.magpointgroupreffromC_4htoS_6.Verification
CPU integration test (4 MPI ranks, 1 OpenMP thread):
-6263.2934665 eV.(Mx, My, Mz) ≈ (+0.6911, +0.6911, +0.6911) μB.(Mx, My, Mz) ≈ (-0.6911, -0.6911, -0.6911) μB.Mysign.GPU validation has not yet been performed.
Scope
Only three existing integration-test files are modified. No production code, additional test cases, or CI configuration changes are introduced.
Related fix: #8250.