Repository navigation
Fix prepare and bind sample metadata argument mapping - #889
Merged
darold merged 1 commit intoOct 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The generated Time consuming prepare and Time consuming bind example details show the wrong database, user, remote host and application. A synthetic log with
db=demo_db,user=demo_user,app=demo_app,client=example.testinstead displays databasepostgres, userdemo_db, remotedemo_user, applicationexample.test, and a spurious query IDdemo_app.Both
store_queriescallers pass the aggregate report database followed by the actual database name toset_top_prepare_bind_sample, but its parameter list omits the actual database name. Every subsequent argument is shifted.Change
Accept that existing argument and store it as the sample's database name, preserving the aggregate report key and all other caller contracts. Three production lines change; a self-contained CLI-to-HTML regression checks both prepare and bind examples.
Validation
fb5e1bfe80e50180e77795bac49653cc92c6813d: 10 of 11 new assertions fail; fixed version passes 11/11 on Perl 5.38.2./tmpoutputs and upstream log fixtures outside this isolated check; optional JSON::XS absent). This PR is independent of Fix multiline prepare query continuation #888.