Repository navigation
Fix prepare and bind user-details toggle targets - #890
Merged
darold merged 1 commit intoOct 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The User(s) involved buttons in the generated Time consuming prepare and Time consuming bind reports cannot open their panels. The buttons target
time-consuming-prepare-user-involved-rank-Nandtime-consuming-bind-user-involved-rank-N, but both panels are emitted with the misspelled IDtime-consuming-prepapre-user-involved-rank-N. When both reports contain the same rank, this also duplicates the panel ID.Change
Correct the two generated IDs to match the existing Bootstrap collapse targets. Add a self-contained synthetic-log CLI-to-HTML regression checking that each button targets its own user-details panel.
Validation
fb5e1bfe80e50180e77795bac49653cc92c6813d: both target assertions fail (1/3 pass); fixed version passes 3/3 on Perl 5.38.2./tmppaths and upstream log fixtures outside the isolated check; JSON::XS absent). No production log or database connection used. Independent of Fix multiline prepare query continuation #888 and Fix prepare and bind sample metadata argument mapping #889.