Skip to content

Add cscore/cameraserver to vdep - #2670

Open
samfreund wants to merge 3 commits into
PhotonVision:mainfrom
samfreund:pull-in-vdep-stuff
Open

samfreund wants to merge 3 commits into
PhotonVision:mainfrom
samfreund:pull-in-vdep-stuff

Conversation

@samfreund

@samfreund samfreund commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Description

What changed?

CameraServer and various CSCore artifacts were added to our vendordep.

Why?

CameraServer was migrated to a vendordep, so we now need to include the artifacts.

Testing

  • I have tested this change locally
  • Test evidence (screenshots, videos, or test results):

Paste screenshots or video links here

Related Issues

Closes #2672


AI Disclosure

  • This PR was authored entirely by me
  • This PR includes AI-generated code (e.g., from GitHub Copilot, ChatGPT)
    • If yes, I have reviewed all AI-generated code for correctness
    • If yes, please describe which parts were AI-assisted:

Merge Checklist

Additional Checks (if applicable)

  • User-facing changes? User documentation is updated
  • Breaking changes? Migration guide is included in description, migration is added to DbMigrations.java, and tests are added to verify the migration works
  • Bug fix? Regression test is added
  • New dependency? License compatibility is verified and steps have been taken to follow it
  • Serde changes? All messages are regenerated with no unexpected hash changes
  • Configuration changes? Changes are backwards compatible with previous season's last release
  • Pipeline/data exchange changes? Frontend types are updated in ./photon-client/src/types

Signed-off-by: samfreund <samf.236@proton.me>
@github-actions github-actions Bot added the photonlib Things related to the PhotonVision library label Nov 9, 2026

@spacey-sooty spacey-sooty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need apriltag as well

Signed-off-by: samfreund <samf.236@proton.me>
mcm001
mcm001 previously approved these changes Nov 12, 2026

@mcm001 mcm001 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against StuyPulse/flock@a039151 and fixes that crash for Java at least

@mcm001 mcm001 mentioned this pull request Nov 12, 2026
15 tasks
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
@spacey-sooty
spacey-sooty marked this pull request as ready for review November 13, 2026 02:13
@spacey-sooty
spacey-sooty requested a review from a team as a code owner November 13, 2026 02:13

@spacey-sooty spacey-sooty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can cause dependency conflicts if a user has both the cscoree or apriltag vendordeps installed and our vendordep installed, per https://discord.com/channels/176186766946992128/1365422855378178048/1570624228854599701

We should declare the apriltag and cscore vendordeps as required instead

@spacey-sooty spacey-sooty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was meant to be request changes lol

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

photonlib Things related to the PhotonVision library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PhotonLib dev fails on WPILib 2027 alpha 8 simulation: cscore.dll not found, then OpenCvLoader ClassNotFoundException

4 participants