Repository navigation
Conversation
Signed-off-by: samfreund <samf.236@proton.me>
spacey-sooty
requested changes
Nov 9, 2026
spacey-sooty
left a comment
Member
There was a problem hiding this comment.
We need apriltag as well
Signed-off-by: samfreund <samf.236@proton.me>
4 of 15 tasks
mcm001
previously approved these changes
Nov 12, 2026
mcm001
left a comment
Contributor
There was a problem hiding this comment.
Tested against StuyPulse/flock@a039151 and fixes that crash for Java at least
spacey-sooty
approved these changes
Nov 13, 2026
spacey-sooty
marked this pull request as ready for review
November 13, 2026 02:13
spacey-sooty
approved these changes
Nov 13, 2026
spacey-sooty
left a comment
Member
There was a problem hiding this comment.
This can cause dependency conflicts if a user has both the cscoree or apriltag vendordeps installed and our vendordep installed, per https://discord.com/channels/176186766946992128/1365422855378178048/1570624228854599701
We should declare the apriltag and cscore vendordeps as required instead
spacey-sooty
requested changes
Nov 13, 2026
spacey-sooty
left a comment
Member
There was a problem hiding this comment.
That was meant to be request changes lol
4 of 15 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What changed?
CameraServer and various CSCore artifacts were added to our vendordep.
Why?
CameraServer was migrated to a vendordep, so we now need to include the artifacts.
Testing
Paste screenshots or video links here
Related Issues
Closes #2672
AI Disclosure
Merge Checklist
Additional Checks (if applicable)
DbMigrations.java, and tests are added to verify the migration works./photon-client/src/types