Repository navigation
Require CameraServer/AprilTag vendordeps - #2673
Open
thatcomputerguy0101 wants to merge 1 commit into
Open
thatcomputerguy0101 wants to merge 1 commit into
thatcomputerguy0101 wants to merge 1 commit into
Conversation
Contributor
Author
|
It might be worth figuring out what the resolution to wpilibsuite/allwpilib#9700 is first before deciding between these two PRs, because if OpenCV is given a custom version alias I think #2670 would give a better user experience. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What changed?
Alternative to #2670 that requires the CameraServer/AprilTag vendordeps directly instead of their Maven artifacts. This requires the CameraServer/AprilTag vendordeps to be manually installed, but prevents hard-to-understand error messages from version conflicts.
Why?
GradleRIO alpha-8 stopped preinstalling the vision libraries.
If a vendordep is missing, an error like the following is printed:
If a conflicting version is found (as can be the case in the other PR), a vague error message like the following is displayed:
Testing
Paste screenshots or video links here
Related Issues
Closes #2672
AI Disclosure
Describe AI involvement here if applicable
Merge Checklist
Additional Checks (if applicable)
DbMigrations.java, and tests are added to verify the migration works./photon-client/src/types