Skip to content

ci: run zsh-lint v1.6.1 in the observe-mode workflow - #212

Merged
ss-o merged 1 commit into
mainfrom
feature-211
Oct 25, 2026
Merged

ss-o merged 1 commit into
mainfrom
feature-211

Conversation

@ss-o

@ss-o ss-o commented Oct 25, 2026

Copy link
Copy Markdown
Member

Pull request

Summary

  • Pin the advisory zsh-lint workflow to the published v1.6.1 release: zsh-lint-ref in .github/workflows/zsh-lint.yml moves from f6341241c398fd2a784452e75895dafb06186bbc # v1.6.0 to 136df813e37d0ec48573929489b44c1841af57ee # v1.6.1 ([dev]: release v1.6.1 with the declaration, quoting and parser fixes zsh-lint#751). The pinned commit is the v1.6.1 tag commit and is on z-shell/zsh-lint main.
  • The paths, zsh-lint.json and observe mode are unchanged.

Closes #211

Verification

  • The organization runner (automation/ci/zsh_lint_ci.py), in observe mode with zsh-lint.json and the workflow's 6 paths, at main c7e2fe4 and on this branch, with zsh-lint built from 136df81:
Analyzer Files Parser errors Errors Warnings Info Hint Result
v1.6.0 58 0 0 0 53 5 passed
v1.6.1 58 0 0 0 53 5 passed
  • Every finding keeps its file, position, rule and severity. Five messages change: quoting/unquoted-var at chroma/_fsh_chroma_subversion lines 192 and 193 and at functions/_fsh_theme_resolve_rendering line 70 (three findings), on single-element subscripts of match and color_rgb, now gives scalar advice instead of suggesting "${match[@]}" or "${color_rgb[@]}" ([bug]: quoting/unquoted-var gives array advice for a single subscripted element zsh-lint#747).
  • trunk check and actionlint on the workflow pass.

Compatibility and lifecycle

No compatibility or lifecycle impact: only the analyzer revision of an advisory CI check changes; no plugin, theme or chroma source changes.

Agent handoff

No handoff needed.

Pin the advisory zsh-lint workflow to the published v1.6.1 release
(136df813e37d0ec48573929489b44c1841af57ee). Paths, configuration and
observe mode are unchanged.

Closes #211
@ss-o ss-o moved this to In Review in Z-shell Delivery Oct 25, 2026
@github-actions

Copy link
Copy Markdown

PR highlighting performance

Buffer Base PR Difference
173 chars 3.278 ms 3.222 ms -1.7%
1000 chars 10.549 ms 10.431 ms -1.1%

Negative differences are faster. Medians use nine parses after one warm-up on the same runner.

Behavioral assertions

  • Pass: representative buffers produce highlighting
  • Pass: steady-state highlighting performs no full lifecycle refresh
  • Pass: buffers above the configured limit take the skip path
  • Pass: lazy and steady-state plugin resources unload cleanly

@ss-o ss-o left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallback review under ADR-0026: maintainer elected, no Copilot request on ef27775

Findings

No actionable findings.

Scope: the complete diff from main at c7e2fe4 to ef27775: one line, .github/workflows/zsh-lint.yml:56, against the acceptance criteria of #211. main on this repository has no Copilot review rule, so no request was made.

Note

This is a maintainer-elected fallback review, not an independent review or an approval to merge.

Validation

  • Passed on the head: all 16 pull-request checks, including the Configured Zsh Lint job on the new pin. No review threads are open.
  • Reproduced for this review: zsh-lint built from the v1.6.1 source and the organization runner (automation/ci/zsh_lint_ci.py) run on the head with the workflow's own 6 paths, zsh-lint.json and observe mode: 58 files, 0 parser errors, 0 errors, 0 warnings, 53 info and 5 hint findings, passed. The diagnostics equal a v1.6.1 run at main; against v1.6.0 only the five quoting/unquoted-var messages the pull request lists change, with every file, range, rule and severity identical. actionlint on the workflow passes.
  • Not part of this change: the Zsh syntax, ZUnit and integration suites; no plugin source changes.
Checklist verdicts and supporting evidence
  • Pin provenance: pass. 136df813e37d0ec48573929489b44c1841af57ee is the commit of the signed v1.6.1 tag of z-shell/zsh-lint and is on its main; the # v1.6.1 comment matches. It replaces the v1.6.0 tag commit f6341241c398fd2a784452e75895dafb06186bbc.
  • Workflow contract: pass. Name, job, triggers, contents: read permissions, caller-owned concurrency, the organization reusable workflow at @main, paths, configuration and observe mode are unchanged.
  • Ref consumption and failure paths: pass. The reusable workflow validates the ref as a 40-character SHA, checks out z-shell/zsh-lint at it without persisted credentials, builds ./cmd/zsh-lint with the Go version from its go.mod, and the runner fails on parser errors, configuration errors, unexpected exit codes or malformed reports even in observe mode. v1.6.0 and v1.6.1 have identical go.mod, go.sum and CLI entry point.
  • Behaviour for this repository: pass. Same counts and result as v1.6.0; five advice messages change.
  • Compatibility and lifecycle: not applicable. No plugin, theme, chroma or completion source changes.
  • Traceability: pass. The body closes #211, the branch is feature-211 and the title follows Conventional Commits.

Limits

  • The v1.6.0 comparison uses the run at main; the head changes no Zsh source.

@ss-o
ss-o merged commit a4bfd52 into main Oct 25, 2026
16 checks passed
@ss-o
ss-o deleted the feature-211 branch October 25, 2026 01:02
@github-project-automation github-project-automation Bot moved this from In Review to Done in Z-shell Delivery Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

feat: run zsh-lint v1.6.1 in the observe-mode workflow

1 participant