Repository navigation
ci: run zsh-lint v1.6.1 in the observe-mode workflow - #212
Merged
Merged
Conversation
Pin the advisory zsh-lint workflow to the published v1.6.1 release (136df813e37d0ec48573929489b44c1841af57ee). Paths, configuration and observe mode are unchanged. Closes #211
PR highlighting performance
Negative differences are faster. Medians use nine parses after one warm-up on the same runner. Behavioral assertions
|
ss-o
commented
Oct 25, 2026
ss-o
left a comment
Member
Author
There was a problem hiding this comment.
Fallback review under ADR-0026: maintainer elected, no Copilot request on ef27775
Findings
No actionable findings.
Scope: the complete diff from main at c7e2fe4 to ef27775: one line, .github/workflows/zsh-lint.yml:56, against the acceptance criteria of #211. main on this repository has no Copilot review rule, so no request was made.
Note
This is a maintainer-elected fallback review, not an independent review or an approval to merge.
Validation
- Passed on the head: all 16 pull-request checks, including the Configured Zsh Lint job on the new pin. No review threads are open.
- Reproduced for this review: zsh-lint built from the
v1.6.1source and the organization runner (automation/ci/zsh_lint_ci.py) run on the head with the workflow's own 6 paths,zsh-lint.jsonand observe mode: 58 files, 0 parser errors, 0 errors, 0 warnings, 53 info and 5 hint findings, passed. The diagnostics equal a v1.6.1 run atmain; against v1.6.0 only the fivequoting/unquoted-varmessages the pull request lists change, with every file, range, rule and severity identical.actionlinton the workflow passes. - Not part of this change: the Zsh syntax, ZUnit and integration suites; no plugin source changes.
Checklist verdicts and supporting evidence
- Pin provenance: pass.
136df813e37d0ec48573929489b44c1841af57eeis the commit of the signedv1.6.1tag of z-shell/zsh-lint and is on itsmain; the# v1.6.1comment matches. It replaces thev1.6.0tag commitf6341241c398fd2a784452e75895dafb06186bbc. - Workflow contract: pass. Name, job, triggers,
contents: readpermissions, caller-owned concurrency, the organization reusable workflow at@main, paths, configuration and observe mode are unchanged. - Ref consumption and failure paths: pass. The reusable workflow validates the ref as a 40-character SHA, checks out
z-shell/zsh-lintat it without persisted credentials, builds./cmd/zsh-lintwith the Go version from itsgo.mod, and the runner fails on parser errors, configuration errors, unexpected exit codes or malformed reports even in observe mode.v1.6.0andv1.6.1have identicalgo.mod,go.sumand CLI entry point. - Behaviour for this repository: pass. Same counts and result as
v1.6.0; five advice messages change. - Compatibility and lifecycle: not applicable. No plugin, theme, chroma or completion source changes.
- Traceability: pass. The body closes #211, the branch is
feature-211and the title follows Conventional Commits.
Limits
- The
v1.6.0comparison uses the run atmain; the head changes no Zsh source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Summary
zsh-lint-refin.github/workflows/zsh-lint.ymlmoves fromf6341241c398fd2a784452e75895dafb06186bbc # v1.6.0to136df813e37d0ec48573929489b44c1841af57ee # v1.6.1([dev]: release v1.6.1 with the declaration, quoting and parser fixes zsh-lint#751). The pinned commit is thev1.6.1tag commit and is on z-shell/zsh-lintmain.zsh-lint.jsonand observe mode are unchanged.Closes #211
Verification
automation/ci/zsh_lint_ci.py), in observe mode withzsh-lint.jsonand the workflow's 6 paths, atmainc7e2fe4 and on this branch, with zsh-lint built from136df81:quoting/unquoted-varatchroma/_fsh_chroma_subversionlines 192 and 193 and atfunctions/_fsh_theme_resolve_renderingline 70 (three findings), on single-element subscripts ofmatchandcolor_rgb, now gives scalar advice instead of suggesting"${match[@]}"or"${color_rgb[@]}"([bug]: quoting/unquoted-var gives array advice for a single subscripted element zsh-lint#747).trunk checkandactionlinton the workflow pass.Compatibility and lifecycle
No compatibility or lifecycle impact: only the analyzer revision of an advisory CI check changes; no plugin, theme or chroma source changes.
Agent handoff
No handoff needed.