Repository navigation
feat(fsh_theme): add AWK example to theme preview - #202
Conversation
PR highlighting performance
Negative differences are faster. Medians use nine parses after one warm-up on the same runner. Behavioral assertions
|
ss-o
left a comment
There was a problem hiding this comment.
Fallback review under ADR-0026: maintainer elected, no Copilot request on 4817d05
No actionable findings. Reviewed the complete one-line diff against base and merge base 14df507cdc9c13af08bd023caa202cd7539d0918, using the bundled organization review criteria and issue #198 as the acceptance criteria.
Self-review; no independent reviewer participated.
- Specification: PASS.
functions/fsh_theme:516adds the exact requestedawk '{print $1}'example. Buffer capture verifies the quotes and literal$1; the AWK chroma produces the background region in the full preview. - Correctness and safety: PASS. The example uses the same quote-escaping pattern as nearby samples. It is literal data passed to the existing
print -zr, inside the existingrepeat 0block. The change adds no execution, input evaluation, filesystem or network operation. - Zsh and compatibility: PASS. The file is a native Zsh autoload function with a declared Zsh 5.8 floor. Native syntax and compilation pass locally on Zsh 5.9.2; hosted Zsh 5.8 and 5.9.2 validation also pass. The added text uses the existing grammar and quoting convention.
- State and lifecycle: PASS. The affected theme persistence integration test passes, including interactive preview rendering, acceptance, Ctrl-C cleanup and preserved theme storage.
- Validation: PASS for the relevant checks. The isolated buffer/highlight check passes on this head and fails against the base because the example is missing.
zsh -f -n,zcompile,zcompile -tandgit diff --checkpass. Hosted ZUnit passes on Linux and macOS, and hosted Trunk passes. The existing Trunk hooks ran; the extensionless change has no applicable local Trunk linters. - Scope, documentation and dependencies: PASS. One file and one added sample line; no public API, configuration, dependencies, CI or documented command contract changes. No documentation update is needed.
All required CI checks pass on the reviewed head, and there are no review threads. Visual rendering in the reporter's terminal was not inspected, and local Zsh 5.8/macOS checks were not run. GitHub Markdown rendering was checked through the API; desktop and narrow-screen visual rendering was not inspected. No follow-up changes are proposed.
Summary
awk '{print $1}'to thefsh_theme --testpreview using the existing single-quote escaping pattern, as suggested in feat: add a single quote command for the tests #198.subtle-bg, keyword and bracket styles. It remains inside the existingrepeat 0sample block.Closes #198.
Verification
zcompile/zcompile -tforfunctions/fsh_theme.$1, and the existing highlighter produces the AWK background region in the full preview. The same check fails on the unchanged base because the sample is absent.env -u FPATH zsh -f tests/integration/test-theme-persistence.zsh, including interactive preview cleanup and theme-storage preservation.git diff --check.Agent handoff
No handoff needed.