Repository navigation
Unify memory presentation through InformationView - #112
Merged
Merged
Conversation
Route shared search, exact evidence and save replies through InformationView while preserving existing text and domain budgets. Memoize disclosure metadata on each immutable output so text-only callers avoid source hashing. Record 15 text parity cases and 12 complete metadata comparisons. All 16 blocking agent:verify checks passed; product tests reported 2071 passed, 2 skipped and 0 failed. Retain the earlier Windows cleanup failure and its 0/10 isolated reproduction result in the experiment report.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
What: Route shared search, exact-evidence and save-reply presentation through InformationView while preserving existing tool text and domain budgets.
Why: A common presentation protocol gives text and structured consumers the same projection. Immutable snapshots and source fingerprints add cost, so disclosure metadata is computed only when requested and memoized within the prepared output.
Changes:
includedis accessed. Confirmation still checks the exact text and reader/session on each call.Not verified
No new live-host integration, recall benchmark, model-answer quality evaluation, or end-to-end retrieval-latency measurement was run for this revision. Other mutation-action confirmations, host errors and JSON/RPC business results remain outside the migrated presentation scope. The synthetic timing results do not establish an end-to-end speedup.
One prior full verification run failed while cleaning up an STG temporary directory on Windows with
EPERMafter the assertions completed; 10 isolated reruns reproduced it 0 times. The cause remains undetermined. A subsequent full run passed. The first pre-push mutation sweep also failed with a Windows file-write error and left one injected mutation; it was restored to HEAD, and the full retry passed with all 23 targets restored byte-identically.Completion checklist
Local quality checks
npm run verify:staticpasses (the equivalent 16 blocking checks inagent:verifypassed; the aggregate command itself was not run)npm run test:productpasses (throughagent:verify: 2,071 passed, 2 skipped, 0 failed)verify:packagespassedcomplexity:gatepassed; the full pre-pushmutation:teethretry passedRCP (Repository Control Plane)
.nmg/verification/latest.jsonnmg-rcp forge-statusCI completion confirmation
All checks passedis SUCCESS