Skip to content

Return TestUtils::done() for all passing test cases - #2910

Open
mmichel11 wants to merge 1 commit into
mainfrom
dev/mmichel11/fix_test_success_return
Open

mmichel11 wants to merge 1 commit into
mainfrom
dev/mmichel11/fix_test_success_return

Conversation

@mmichel11

Copy link
Copy Markdown
Contributor

Some internal CI harnesses check a success message in addition to checking the return code. 24 tests pass without printing "done", which were causing false positive failures.

@mmichel11
mmichel11 marked this pull request as ready for review November 18, 2026 21:02

@danhoeflinger danhoeflinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergeyKopienko SergeyKopienko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…t success

Several tests returned 0 from main without calling TestUtils::done(), so
they never printed the success keyword expected by some test harnesses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mmichel11
mmichel11 force-pushed the dev/mmichel11/fix_test_success_return branch from fef4ab4 to c215b2d Compare November 20, 2026 21:28

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants