Repository navigation
fix: upgrade distro packages in the final stage - #24
Merged
Merged
Conversation
Packages from the base image and from `apk add` only pick up Alpine security fixes when the build upgrades them, so a rebuild without a base digest change shipped the same vulnerable versions. The daily CVE rebuild job in appwrite/renovate-config relies on a fresh build picking up those fixes.
🟢 Tier S · Ready to merge
The final image stage now upgrades installed Alpine packages before adding its runtime dependencies. This lets fresh builds include package fixes available in the configured Alpine repositories even when the PHP base image digest is unchanged.
📂 Walkthrough · 1
Reviewed |
![appwrite[bot]](https://avatars.githubusercontent.com/in/325556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
RUN apk upgrade --no-cacheright after the final stageFROM, so a rebuild picks up Alpine package fixes even when the base image digest hasn't moved. This is what lets the daily fixable-CVE rebuild job in appwrite/renovate-config cut a patch release when a fresh build scans cleaner than the published tag.Clears code-scanning alert #103 (CVE-2026-4738, zlib 1.3.2-r1 → 1.4-r0).