Repository navigation
fix(sqlite): support TimeField values - #2297
Merged
waketzheng merged 16 commits intoOct 29, 2026
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The adapter integrates consistently with existing SQLite conversions and the new test covers the reported failure paths.
Review effort: Balanced
Findings: None
What changed in this PR
Adds SQLite support for persisting and querying TimeField values.
Changes:
- Registers SQLite adaptation for
datetime.time. - Adds create, retrieve, and filter coverage.
- Documents the fix in the changelog.
| File | Description |
|---|---|
tortoise/backends/sqlite/executor.py |
Adds ISO-format time adaptation. |
tests/fields/test_time.py |
Verifies SQLite time persistence and filtering. |
CHANGELOG.rst |
Records the SQLite fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Merging this PR will not alter performance1 warning
Comparing |
waketzheng
requested changes
Oct 7, 2026
…atabase-url-username-decoding
…-timefield-support
…re/sqlite-timefield-support
…re/sqlite-timefield-support
waketzheng
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add SQLite DB-API adaptation for
datetime.time, allowingTimeFieldvalues to be created, retrieved, and filtered.Motivation and Context
SQLite currently rejects a bound
datetime.timewithsqlite3.ProgrammingError, despite Tortoise exposingTimeFieldand generating aTIMEcolumn. Fixes #2296.How Has This Been Tested?
uv run pytest tests/fields/test_time.py -qpre-commit run --files CHANGELOG.rst tortoise/backends/sqlite/executor.py tests/fields/test_time.pyChecklist: