Repository navigation
Conversation
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit ed0db06 |
brendt
left a comment
There was a problem hiding this comment.
Can you add pattern tests please? Look at any other language pattern to see how they work.
brendt
left a comment
There was a problem hiding this comment.
Can you add pattern tests please? Look at any other language pattern to see how they work.
|
Sorry for the double review |
|
Added Verified locally before pushing: |
bbc00d9 to
aec9b0b
Compare
|
Rebased onto current Verified locally after the rebase: |
aec9b0b to
ed0db06
Compare
Summary
tomlThis is a clean resubmission of the closed #227, based directly on
main: no core changes and no visual test harness.Verification
vendor/bin/php-cs-fixer fix --allow-risky=yes— no remaining changesvendor/bin/phpstan analyse src tests— no errorsvendor/bin/phpunit— 865 tests, 1,170 assertionsvendor/bin/phpbench run tests/Bench/HighlighterBench.php --variant='^toml$' --report=aggregate— 100.64 μs (±0.54%)Screenshot