Repository navigation
Conversation
|
Follow-up commit after an independent review pass over this branch:
Full suite after the change: 868 tests, 1,133 assertions; PHPStan and PHP-CS-Fixer clean. |
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit 98ad83f |
brendt
left a comment
There was a problem hiding this comment.
Can you add pattern tests please? Look at any other language pattern to see how they work.
|
Added Verified locally after the change: |
2894666 to
7e70828
Compare
|
Rebased onto current Verified locally after the rebase: |
7e70828 to
98ad83f
Compare
Summary
rustandrsThis is a clean resubmission of the closed #221, based directly on
main. It follows the review there: no core changes (Escape,Highlighter::parse, and the diff injections are untouched apart from registering the language), no visual test harness, attributes match only the#[pathprefix so a]inside a string no longer duplicates rendered text, and possessive quantifiers avoid PCRE backtracking errors on unterminated block comments and long whitespace runs.Verification
composer validate --strictvendor/bin/php-cs-fixer fix --allow-risky=yes— no remaining changesvendor/bin/phpstan analyse src tests— no errorsvendor/bin/phpunit— 858 tests, 1,121 assertionsvendor/bin/phpbench run tests/Bench/HighlighterBench.php --variant='^rust$' --report=aggregate— 143.79 μs (±0.57%)Screenshot