Repository navigation
Conversation
The C++ blst::bytes_t typemap decrements the reference to the UTF-8 copy of a 'str' argument right after taking a pointer into it, so the wrapped method reads freed memory and the freearg typemap releases the object a second time. Leave the release to freearg.
Collaborator
|
Oops! I've removed one, but missed this one. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the str branch of the C++ blst::bytes_t Python typemap calls Py_DECREF on the PyUnicode_AsUTF8String temporary right after taking a pointer into it, so the wrapped method (P{1,2}.hash_to, core_verify, Pairing.aggregate, SecretKey.keygen, ...) reads freed memory and freearg then releases the object a second time; hashing str messages in a loop against their .encode() form segfaults or aborts the interpreter on the current tree, so the early release is dropped and run.me now checks str/bytes agreement.