Repository navigation
Conversation
Collaborator
|
Good point, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blst::Pairing is an empty class whose actual state, the blst_pairing context, lives in the blst_pairing_sizeof() bytes handed out by its class-specific operator new, so it extends well past sizeof(Pairing). The compiler-generated copy constructor and copy assignment still exist, and they copy nothing. As a result new blst::Pairing(*ctx) returns an object whose whole context, DST pointer included, is uninitialized operator-new memory, and deleting it makes ~Pairing() call delete[] on that garbage pointer, while *dst = *src silently leaves dst with its own previous aggregation state. I noticed it while reading the class alongside the Java path that relocates the context, and ASan confirms it with a SEGV in operator delete[] called from ~Pairing (blst.hpp:938) on the copied object. Deleting both special members turns these uses into compile errors and suppresses the implicit move members as well; they sit in the existing #ifndef SWIG block next to operator new/delete, so the SWIG interface is unchanged and the Python and node.js run.me tests still pass. Declaring a Pairing with automatic storage overflows the stack in the same way and is not addressed here, since preventing that would take an interface change.