Repository navigation
Conversation
extract_from_op_expr swaps `const op col` into `col op const` so the column is on the left, but kept the original operator. `10 < col` was therefore pushed down as `col < 10`: the remote side returned the wrong rows and the local recheck filtered them out, so scans silently returned fewer (often zero) rows. With aggregate pushdown, which has no recheck, the aggregate itself was computed over the wrong rows. The operator is now replaced by its commutator (`oprcom`) when swapping.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extract_from_op_exprswapsconst op colintocol op constso the column is on the left, but kept the original operator.25 < agewas pushed down asage < 25, i.e. with the comparison reversed:The operator is now replaced by its commutator (
oprcom) when swapping. Operators without a commutator are still not swapped.$1 < col(PARAM_EXTERN) goes through the same path and is fixed as well.Validation
mysql_swapped_qual_testcovers<,>,<=,>=,=,<>and a timestamp comparison written asconst op col.cargo fmt --check,cargo clippy -D warnings(pg15 mysql_fdw),cargo pgrx testmysql tests on pg15 and pg18 pass.25 < agereturns[]instead of[2, 3]).