Skip to content

ci: prune unused Docker publish workflows and telemetry secrets - #7699

Open
kanadgupta wants to merge 1 commit into
developfrom
kanad-claude/cli-secrets-audit-293866
Open

kanadgupta wants to merge 1 commit into
developfrom
kanad-claude/cli-secrets-audit-293866

Conversation

@kanadgupta

@kanadgupta kanadgupta commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

Reduces the Actions secrets these workflows need.

  • Deletes publish-migra.yml and publish-pg-prove.yml. Both are manual-run only and have no recorded runs. The CLI pulls these images from public.ecr.aws, and the mirror workflows keep that registry up to date. This leaves the DOCKER_USERNAME and DOCKER_PASSWORD secrets unused on this branch.
  • Reads POSTHOG_ENDPOINT from a repository variable instead of a secret. The build bakes the endpoint into the published CLI, so it isn't sensitive. POSTHOG_API_KEY stays a secret.
  • Stops passing SENTRY_DSN to the build. Nothing has read it since the Go binary was removed.

Backport

#7701 brings the same cleanup to v2.x, with one difference: SENTRY_DSN stays a secret there. The v2 Go binary uses it to send an error report to Sentry when a user passes --create-ticket.

Linked issue

Part of CLI-3161

🤖 Generated with Claude Code

Remove the never-run migra and pg_prove Docker Hub publish workflows,
read the PostHog endpoint from a repository variable, and stop passing
the Sentry DSN that no current build reads.

Generated with AI

Co-Authored-By: Claude <noreply@anthropic.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

CLI reference prose guidance: not applicable (no reference sources changed).

Both reviewers identified the same release configuration issue. The fallback is confirmed, and the checkout does not show whether the new Actions variable has been provisioned. Coordinate the endpoint migration with the active v2.x maintenance branch, which still reads the endpoint secret and uses SENTRY_DSN in its Go build.

Findings

Severity Location Category Sources Claim
🟡 MINOR .github/workflows/build-cli-artifacts.yml:52 release-config claude+codex If POSTHOG_ENDPOINT is configured only as a secret, release builds succeed with an empty embedded endpoint. Without a runtime host override, the CLI silently uses https://eu.i.posthog.com, so opted-in telemetry can be sent to a different host than intended.

Stats

Claude findings: 1 · Codex findings: 1 · Confirmed: 1 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.2-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant