Repository navigation
ci: prune unused Docker publish workflows and telemetry secrets - #7699
Open
kanadgupta wants to merge 1 commit into
Open
kanadgupta wants to merge 1 commit into
kanadgupta wants to merge 1 commit into
Conversation
Remove the never-run migra and pg_prove Docker Hub publish workflows, read the PostHog endpoint from a repository variable, and stop passing the Sentry DSN that no current build reads. Generated with AI Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🤖 AI Review
CLI reference prose guidance: not applicable (no reference sources changed).
Both reviewers identified the same release configuration issue. The fallback is confirmed, and the checkout does not show whether the new Actions variable has been provisioned. Coordinate the endpoint migration with the active v2.x maintenance branch, which still reads the endpoint secret and uses SENTRY_DSN in its Go build.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | .github/workflows/build-cli-artifacts.yml:52 |
release-config |
claude+codex | If POSTHOG_ENDPOINT is configured only as a secret, release builds succeed with an empty embedded endpoint. Without a runtime host override, the CLI silently uses https://eu.i.posthog.com, so opted-in telemetry can be sent to a different host than intended. |
Stats
Claude findings: 1 · Codex findings: 1 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.2-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces the Actions secrets these workflows need.
publish-migra.ymlandpublish-pg-prove.yml. Both are manual-run only and have no recorded runs. The CLI pulls these images frompublic.ecr.aws, and the mirror workflows keep that registry up to date. This leaves theDOCKER_USERNAMEandDOCKER_PASSWORDsecrets unused on this branch.POSTHOG_ENDPOINTfrom a repository variable instead of a secret. The build bakes the endpoint into the published CLI, so it isn't sensitive.POSTHOG_API_KEYstays a secret.SENTRY_DSNto the build. Nothing has read it since the Go binary was removed.Backport
#7701 brings the same cleanup to
v2.x, with one difference:SENTRY_DSNstays a secret there. The v2 Go binary uses it to send an error report to Sentry when a user passes--create-ticket.Linked issue
Part of CLI-3161
🤖 Generated with Claude Code