Repository navigation
chore(cli): declare experimental access and deprecation on commands - #7698
Open
mdonnalley wants to merge 5 commits into
Open
mdonnalley wants to merge 5 commits into
mdonnalley wants to merge 5 commits into
Conversation
Contributor
CLI benchmark (Lightweight Commands): no changes foundCommit
API calls: unchanged for all 9 commands. Binary size: 135.3 MB, up 4.0 KB from 135.2 MB. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate the CLI reference from command annotations instead of maintaining separate lists of experimental and deprecated commands. Parent help and shell completion derive the
(deprecated)label from the same annotation that excludes a command from the website. Deprecated commands remain callable.For experimental access, the command annotates the policy and its handler explicitly checks that policy. This preserves which error users see first:
network-bans getvalidates the output format before checking access, whiledb schema declarative syncreads project config before checking access. CI checks that the annotation and handler reference the same policy. The annotation does not itself enforce access.