Skip to content

fix(storage): align wire requests and metadata handling - #41

Merged
zoedsoupe merged 7 commits into
mainfrom
fix/november-storage-wire-parity
Nov 17, 2026
Merged

zoedsoupe merged 7 commits into
mainfrom
fix/november-storage-wire-parity

Conversation

@zoedsoupe

@zoedsoupe zoedsoupe commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Problem

  • list sent GET to a POST-only route and used the wrong request key names.
  • move and copy used snake_case keys on the wire.
  • update_bucket could not encode nested file size limits.
  • URL transforms forced defaults and could emit null fields in signed requests.
  • list_v2 ignored the API's nextCursor and pinned client defaults.

Solution

  • Keep explicit transform fields only in single and multiple signed URL requests.
  • Use the native JSON module for metadata encoding and request assertions, as requested.
  • Verify exact request methods, decoded JSON payloads and pagination handling. Tests: 148 passing in storage-ex.

Rationale

Wire translation stays localized at the request boundary, keeping existing Elixir schema forms such as destination_bucket and public return keys such as cursor. Omitting client-forced defaults lets the Storage service determine unspecified behavior. This PR excludes other storage bugs, December feature work and the core-dependent release gate.

@zoedsoupe
zoedsoupe merged commit cd887bd into main Nov 17, 2026
24 checks passed
@zoedsoupe zoedsoupe mentioned this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant