Repository navigation
fix: ADDON-91029 scope observability app.conf lookup to the owning add-on - #470
Open
Sudesh0119 wants to merge 3 commits into
Open
Sudesh0119 wants to merge 3 commits into
Sudesh0119 wants to merge 3 commits into
Conversation
…d-on The unscoped app.conf lookup merged every installed app, so telemetry could be labelled with another add-on's name and version. Detect the bundling app from solnlib's install path and scope the lookup to it. No public API or method signature changes. Co-Authored-By: Claude Code <noreply@anthropic.com>
Sudesh0119
force-pushed
the
fix/observability-app-scope
branch
from
October 27, 2026 09:09
707a332 to
0d589ed
Compare
solnlib's own __file__ is already symlink-resolved (sys.path[0] is realpath'd), and SPLUNK_ETC may be relocated. Detect the app from the main script first, fall back to solnlib's path, and accept SPLUNK_ETC. Co-Authored-By: Claude Code <noreply@anthropic.com>
Prefer the outermost etc/apps match, compare paths case-insensitively on Windows, tolerate a missing sys.argv or path errors, and keep detection failures inside _read_ta_info so the solnlib-path fallback still applies. Co-Authored-By: Claude Code <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Telemetry could report the wrong add-on name and version (ADDON-91029).
ObservabilityService._read_ta_info()readapp.confwithout scoping it to an app, so on a host with several add-ons it could pick up another add-on's[id]stanza. For example, the GCP add-on reported itself asSplunk_TA_cyberark 1.2.0.The fix:
etc/apps/<app>/...).app.conf.[id] nameis missing, it uses the app folder name instead.Compatibility
splunkenv._get_app_name_from_path.ta_name/ta_version, or that overrideStanzaObservabilityRecorder._get_or_create_service(Salesforce, GCP PR #1027), behave the same as on 8.2.0.Test plan
lib/,aob_py3, andlib/3rdpartyinstall folders): identity is now correct, and explicit identity and subclass overrides behave the same🤖 Generated with Claude Code