Skip to content

Honor the selected art root in the GotA browser packer - #130

Merged
relh merged 1 commit into
mainfrom
fix/gota-packer-art-root-103
Nov 22, 2026
Merged

relh merged 1 commit into
mainfrom
fix/gota-packer-art-root-103

Conversation

@relh

@relh relh commented Nov 22, 2026

Copy link
Copy Markdown
Contributor

Fixes #103.

The replay builder resolves POLYWORLD_ART, and the Emscripten recipe passes it as the native packer's first argument. GotA still opened its character manifest, part descriptors, and neutral roster through the default sibling directory while constructing the pack list. Use the packer's argument for those reads and keep the declared bundle paths relative to the art root.

Verified against main b819303 with the Coworld art pin a1b88e5 in an alternate directory. From an empty working directory, the original packer failed opening ../polyworld_art/characters/chargen/manifest.json. The fixed packer produced 1,015 files totaling 41,431,595 bytes. The staged manifest, neutral roster, and a part descriptor matched their inputs byte for byte. Repeating the pack with a relative path to the same art reused the cache.

The focused check can be run with the repository's Nim dependencies available:

POLYWORLD_ART=/path/to/art games/gods_of_the_arena/tests/manual_pack_art_root.sh

@relh
relh merged commit c9fce38 into main Nov 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GotA browser asset packer ignores POLYWORLD_ART

1 participant