Repository navigation
Honor the selected art root in the GotA browser packer - #130
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103.
The replay builder resolves
POLYWORLD_ART, and the Emscripten recipe passes it as the native packer's first argument. GotA still opened its character manifest, part descriptors, and neutral roster through the default sibling directory while constructing the pack list. Use the packer's argument for those reads and keep the declared bundle paths relative to the art root.Verified against main
b819303with the Coworld art pina1b88e5in an alternate directory. From an empty working directory, the original packer failed opening../polyworld_art/characters/chargen/manifest.json. The fixed packer produced 1,015 files totaling 41,431,595 bytes. The staged manifest, neutral roster, and a part descriptor matched their inputs byte for byte. Repeating the pack with a relative path to the same art reused the cache.The focused check can be run with the repository's Nim dependencies available: