Skip to content

Fix CaC reference-player comparison on Windows checkouts - #129

Merged
relh merged 1 commit into
mainfrom
fix-cac-windows-reference
Nov 21, 2026
Merged

relh merged 1 commit into
mainfrom
fix-cac-windows-reference

Conversation

@relh

@relh relh commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

The Windows CaC suite on main and #127 stopped in the reference-player parity fixture. Archer occupies 17,717 bytes with CRLF. Searching that source for a quote immediately followed by LF returned -1, which the test used as its first slice index.

Compare whole script lines across the existing title separator and setup block. Assert the boundaries before slicing. This keeps the shared comments and policy body in the comparison and accommodates the multiclass bot’s two-line title.

Reproduced the exact IndexDefect at test_base.nim line 48 on the base revision with the four real policy files checked out as CRLF. After the change, the complete test_base.nim regression passed with both CRLF and LF. Used one compiler worker, a 300-second cap per run and 16 MiB scratch.

Windows failure on #127 · Same failure on main

@relh
relh merged commit 4312318 into main Nov 21, 2026
4 checks passed
relh added a commit that referenced this pull request Nov 21, 2026
…127)

* Share BASIC mailbox decoding and document game delivery

* Add desktop GotA replay library

* Keep GotA replay saving desktop only

* Add desktop LvD replay library

* Add desktop CaC replay library

* Share desktop replay workflows across games

* Support game styled replay libraries

* Document strict Galcon replay versions

* Standardize runtime screenshot capture across games

* Unify common command line options across games

* Add screen-space shockwave, heat, and shield distortion

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Fix small replay and resource bars

* Support existing Silky atlas layouts

* Compare CaC reference scripts by line across checkout formats (#129)

---------

Co-authored-by: treeform <starplant@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
relh added a commit that referenced this pull request Nov 21, 2026
)

* Verify the local Moss conversation workflow and report failed prompt captures

* Add desktop GotA replay library

* Keep GotA replay saving desktop only

* Add desktop LvD replay library

* Add desktop CaC replay library

* Share desktop replay workflows across games

* Support game styled replay libraries

* Document strict Galcon replay versions

* Standardize runtime screenshot capture across games

* Unify common command line options across games

* Add screen-space shockwave, heat, and shield distortion

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Fix small replay and resource bars

* Support existing Silky atlas layouts

* Compare CaC reference scripts by line across checkout formats (#129)

* Share mailbox decoding and document delivery through the BASIC hosts (#127)

* Share BASIC mailbox decoding and document game delivery

* Add desktop GotA replay library

* Keep GotA replay saving desktop only

* Add desktop LvD replay library

* Add desktop CaC replay library

* Share desktop replay workflows across games

* Support game styled replay libraries

* Document strict Galcon replay versions

* Standardize runtime screenshot capture across games

* Unify common command line options across games

* Add screen-space shockwave, heat, and shield distortion

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Fix small replay and resource bars

* Support existing Silky atlas layouts

* Compare CaC reference scripts by line across checkout formats (#129)

---------

Co-authored-by: treeform <starplant@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: treeform <starplant@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant