Repository navigation
Fix CaC reference-player comparison on Windows checkouts - #129
Merged
Merged
Conversation
relh
added a commit
that referenced
this pull request
Nov 21, 2026
…127) * Share BASIC mailbox decoding and document game delivery * Add desktop GotA replay library * Keep GotA replay saving desktop only * Add desktop LvD replay library * Add desktop CaC replay library * Share desktop replay workflows across games * Support game styled replay libraries * Document strict Galcon replay versions * Standardize runtime screenshot capture across games * Unify common command line options across games * Add screen-space shockwave, heat, and shield distortion Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fix small replay and resource bars * Support existing Silky atlas layouts * Compare CaC reference scripts by line across checkout formats (#129) --------- Co-authored-by: treeform <starplant@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
relh
added a commit
that referenced
this pull request
Nov 21, 2026
) * Verify the local Moss conversation workflow and report failed prompt captures * Add desktop GotA replay library * Keep GotA replay saving desktop only * Add desktop LvD replay library * Add desktop CaC replay library * Share desktop replay workflows across games * Support game styled replay libraries * Document strict Galcon replay versions * Standardize runtime screenshot capture across games * Unify common command line options across games * Add screen-space shockwave, heat, and shield distortion Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fix small replay and resource bars * Support existing Silky atlas layouts * Compare CaC reference scripts by line across checkout formats (#129) * Share mailbox decoding and document delivery through the BASIC hosts (#127) * Share BASIC mailbox decoding and document game delivery * Add desktop GotA replay library * Keep GotA replay saving desktop only * Add desktop LvD replay library * Add desktop CaC replay library * Share desktop replay workflows across games * Support game styled replay libraries * Document strict Galcon replay versions * Standardize runtime screenshot capture across games * Unify common command line options across games * Add screen-space shockwave, heat, and shield distortion Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fix small replay and resource bars * Support existing Silky atlas layouts * Compare CaC reference scripts by line across checkout formats (#129) --------- Co-authored-by: treeform <starplant@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: treeform <starplant@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows CaC suite on main and #127 stopped in the reference-player parity fixture. Archer occupies 17,717 bytes with CRLF. Searching that source for a quote immediately followed by LF returned -1, which the test used as its first slice index.
Compare whole script lines across the existing title separator and setup block. Assert the boundaries before slicing. This keeps the shared comments and policy body in the comparison and accommodates the multiclass bot’s two-line title.
Reproduced the exact IndexDefect at test_base.nim line 48 on the base revision with the four real policy files checked out as CRLF. After the change, the complete test_base.nim regression passed with both CRLF and LF. Used one compiler worker, a 300-second cap per run and 16 MiB scratch.
Windows failure on #127 · Same failure on main