Repository navigation
Conversation
Co-authored-by: GPT-6 <noreply@openai.com>
Co-authored-by: Codex (GPT-6) <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mixed Coworld rosters currently reach the file loader even when a seat is a container. This adds an opt-in transport for
coworld-play-seats/2, authenticates remote seats, and preserves file-only log/status ownership.The game retains observation/action semantics. The transport bounds messages and queues, allows one reply per observation, rejects duplicate controllers, and reports disconnect/timeout/overflow explicitly. Existing file-only manifests keep their stored roster format.
Validation: the cooperative CvC consumer compiled against this commit. Full 10,000-tick all-file, mixed, and all-container episodes matched their native replay results. Unauthorized tokens, duplicate connections, invalid BASIC, invalid actions, and malformed JSON were checked. The original reference-player Docker image also completed alongside seven BASIC seats. Private log separation passed.
Draft pending platform-hosted Kubernetes certification and game-owner review. Native processes and cached Docker provide the current evidence; no production resources changed. The integration guide documents the opt-in API and ownership boundary.
Consumer implementation: cooperative CvC draft. The existing FourScore hosted full-match/private-log and compilation-failure scenarios also pass.
Follow-up
927042c4fixes the Linux CI compilation failure in shared window settings. Linux reads X11 root-desktop bounds directly; macOS and Windows retain their existing screen enumeration. The X11 connection is closed after each query. X11 root bounds describe the desktop rather than per-monitor work areas.Validation with the PR's pinned dependency revisions:
getScreens; the corrected source passes.nim check --os:linux --cpu:amd64 --hints:off -d:release -d:bassyNativeStrict -d:replayEvents tests/all.nim: passed.nim r --hints:off -d:release -d:bassyNativeStrict -d:replayEvents tests/all.nim: complete native macOS suite passed.git diff --check: passed.Linux developer qualification at
b285459:tests/manual_displays.nimpassed the windowed → fullscreen → windowed transition (1600×900 → 1920×1080 → 1600×900). A separate 1280×800 root clamped a 4K request to 1200×660.ae5bc282with this engine. Its mixed process/WebSocket case used BASIC in even slots and authenticated remote players in odd slots. It completed 10,000 ticks, rejected wrong tokens and duplicate connections, matched native replay output, and kept file-seat logs and status private. The replay SHA-256 before and after the graphical fix was49f15eb30b9dcaf0991c8217e525cd12a7d09bcfb7f4d8396102c65dea1eb91b.The PR remains draft. CvC game owners must decide whether the adapted map distribution, automated Clips behavior, and reconstructed 74-feature Machina observations are acceptable for cooperative play. Hosted certification and any official switch remain separate gates. Consumer review gates
[Codex (GPT-6), acting on behalf of Richard Higgins]
Merge qualification at
aa87f10incorporates mainb819303. The mixed-seat transport files match the previously qualified draft byte for byte. The current shared launcher and desktop-fullscreen paths are retained. The single dependency lock uses main’s Windy baseline plus the same X11 property fix.On the Linux scratch host, Xvfb/llvmpipe passed the 1600×900 → 1920×1080 fullscreen → 1600×900 round trip and clamped the 4K preset to 1200×660 on a 1280×800 root. The rebuilt cooperative consumer passed the real four-file/four-WebSocket 10,000-tick scenario and reproduced the replay hash recorded above. Three-platform CI passed. The game-owner review hold remains in place.