Skip to content

[CRE-7136] Fail remote executable requests early on unreachable quorum after an error - #24169

Merged
bolekk merged 1 commit into
developfrom
cre-7136-quorum-unreachable-on-error
Nov 10, 2026
Merged

bolekk merged 1 commit into
developfrom
cre-7136-quorum-unreachable-on-error

Conversation

@bolekk

@bolekk bolekk commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

CRE-7136

The remote executable client checks whether quorum is still reachable only on OK responses. OnError never does, so a mix of OK and error responses can leave every quorum unreachable while the request keeps waiting. Example with N=4, F=1: OK(A), OK(B), err(x), err(y). The request then hangs until expiry, which can take up to ~2×timeout+10s because the expiry ticker period equals the timeout.

  • After the existing error-quorum checks, OnError fails with the existing ConsensusFailed "response quorum unreachable" error once neither an OK quorum nor any error quorum can still be reached.
  • While an identical-error quorum is still reachable it keeps waiting, so the request resolves with the real error rather than the generic one.

Client-side only, no wire change, so a staged rollout is safe.

Deployment Validation

Existing canaries; response quorum unreachable, failing early warnings may appear where requests previously timed out.

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

…m after an error

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bolekk
bolekk force-pushed the cre-7136-quorum-unreachable-on-error branch from eb1edeb to 463fa0e Compare November 9, 2026 23:34
@bolekk
bolekk marked this pull request as ready for review November 9, 2026 23:34
@bolekk
bolekk requested review from a team as code owners November 9, 2026 23:34
@bolekk
bolekk requested a review from russell-stern November 9, 2026 23:34
@bolekk
bolekk added this pull request to the merge queue Nov 10, 2026
Merged via the queue into develop with commit 8fb3422 Nov 10, 2026
239 checks passed
@bolekk
bolekk deleted the cre-7136-quorum-unreachable-on-error branch November 10, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants