Skip to content

[CRE] (feat): validate OCR key bundles against expected signers in ProposeJobSpec - #24164

Open
justinkaseman wants to merge 1 commit into
developfrom
CRE-7279
Open

justinkaseman wants to merge 1 commit into
developfrom
CRE-7279

Conversation

@justinkaseman

Copy link
Copy Markdown
Contributor

Makes ProposeJobSpec.VerifyPreconditions check that each target node’s OCR2 key bundle in JD matches an expected onchain signer before a job spec is proposed.

Applies to OCR3, Consensus, Ring, EVM, Aptos, Solana and Stellar.

  • EVM: the bundle ID must be non-empty and its signer must match.
  • Non-EVM: the bundle must be present, with a non-empty ID not shared between nodes.

Why

A stale JD chain config, for example after a key rotation, would bake the wrong bundle ID into the spec.

CLD Follow up

  • Update ProposeJobSpecResolver to fill expected signers
  • Add skipKeyringCheck to the resolver input and pass it through
  • Reject an empty expectedSigners map in the resolver. Otherwise an environment with no signers silently skips the check.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

👋 justinkaseman, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant