Skip to content

[CRE-7294] Fix double counting of capability concurrency limit - #24163

Merged
bolekk merged 1 commit into
developfrom
cre-7294-bugfix-double-count
Nov 6, 2026
Merged

bolekk merged 1 commit into
developfrom
cre-7294-bugfix-double-count

Conversation

@bolekk

@bolekk bolekk commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Each capability call acquired two slots from the same per-workflow CapabilityConcurrency pool: one in the WASM host (PendingCallsLimiter) and one in the engine. Under bursts, executions holding their first slot could starve each other and hang until the execution timeout.

The WASM host now gets its own pool (WASMModulePendingCalls) with the same limit, so each call takes one slot from each pool.

JIRA: CRE-7294

Deployment Validation

resource_PerWorkflow_CapabilityConcurrencyLimit_usage drops ~2x on upgraded nodes vs. non-upgraded nodes in the same DON, and is never pinned at its limit during bursts.

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@bolekk
bolekk marked this pull request as ready for review November 6, 2026 21:14
@bolekk
bolekk requested a review from a team as a code owner November 6, 2026 21:14
@bolekk
bolekk requested a review from jmank88 November 6, 2026 21:14
@trunk-io

trunk-io Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge

Failed Test Failure Summary Logs
Test_CRE_V2_ShardFailoverConfidentialWorkflows The test failed because the Vault public-key request could not reach quorum, with fewer than the required three matching responses. Logs ↗︎

View Full Report ↗︎ ⋅ Docs

@bolekk
bolekk requested a review from justinkaseman November 6, 2026 21:39
@bolekk
bolekk added this pull request to the merge queue Nov 6, 2026
Merged via the queue into develop with commit 09b92cd Nov 6, 2026
324 of 326 checks passed
@bolekk
bolekk deleted the cre-7294-bugfix-double-count branch November 6, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants