Skip to content

[CRE-7122] align shard admission delivery logs - #24159

Merged
MStreet3 merged 1 commit into
developfrom
CRE-7122_align_shard_admission_delivery_logs
Nov 5, 2026
Merged

[CRE-7122] align shard admission delivery logs#24159
MStreet3 merged 1 commit into
developfrom
CRE-7122_align_shard_admission_delivery_logs

Conversation

@agparadiso

@agparadiso agparadiso commented Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This pr aims to tackle some gaps that were present on logs between legacy and coordinated engine on shard admission delivery. It also introduces a parity check test that validates this does not drifts in the future
CRE-7122

Requires

Supports

Deployment Validation Steps

@agparadiso
agparadiso force-pushed the CRE-7122_align_shard_admission_delivery_logs branch from b3f1f28 to 356b994 Compare November 5, 2026 17:20
@agparadiso
agparadiso marked this pull request as ready for review November 5, 2026 17:21
@agparadiso
agparadiso requested a review from a team as a code owner November 5, 2026 17:21
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io

trunk-io Bot commented Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

MStreet3
MStreet3 previously approved these changes Nov 5, 2026
View reviewed changes
jmank88
jmank88 previously approved these changes Nov 5, 2026
View reviewed changes
@agparadiso
agparadiso dismissed stale reviews from jmank88 and MStreet3 via 160e976 November 5, 2026 19:28
@agparadiso
agparadiso force-pushed the CRE-7122_align_shard_admission_delivery_logs branch from 356b994 to 160e976 Compare November 5, 2026 19:28
@agparadiso
agparadiso enabled auto-merge November 5, 2026 19:30
@agparadiso
agparadiso force-pushed the CRE-7122_align_shard_admission_delivery_logs branch from 160e976 to 4392621 Compare November 5, 2026 19:34
@MStreet3
MStreet3 added this pull request to the merge queue Nov 5, 2026
Merged via the queue into develop with commit 0111246 Nov 5, 2026
238 checks passed
@MStreet3
MStreet3 deleted the CRE-7122_align_shard_admission_delivery_logs branch November 5, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmank88 jmank88 jmank88 approved these changes
@MStreet3 MStreet3 MStreet3 approved these changes
@nolag nolag Awaiting requested review from nolag

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@agparadiso @jmank88 @MStreet3