Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
👋 dimriou, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
product-security-plaid-production
Bot
requested review from
justinkaseman and
vyzaldysanchez
November 4, 2026 19:16
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Converting the fee multiplier to float32 introduces precision loss that can underprice transactions, so decimal precision must be preserved through multiplication and covered by a regression test.
1 open issue
What changed in this PR
Adds configurable fee boosting to TxM v2 for Base, connecting chain configuration to transaction fee calculation.
Changes:
- Adds
FeeMultiplierconfiguration, validation, and documentation. - Scales estimated fees, applies a floor when boosting is enabled, and caps fees at the sender’s maximum.
- Adds fee-calculation and compatibility tests and updates builder call sites.
| File | Description |
|---|---|
pkg/txmgr/builder.go |
Passes fee configuration into the attempt builder. |
pkg/txm/txm_test.go |
Updates transaction-flow tests to the configurable constructor. |
pkg/txm/integration-tests/integration_test.go |
Updates integration setup to pass builder configuration. |
pkg/txm/attempt_builder.go |
Implements fee scaling and floors while retaining the existing constructor. |
pkg/txm/attempt_builder_test.go |
Tests multipliers, floors, caps, and backward compatibility. |
pkg/config/toml/testdata/config-full.toml |
Adds a multiplier configuration example. |
pkg/config/toml/docs.toml |
Documents multiplier behavior and constraints. |
pkg/config/toml/config.go |
Adds multiplier parsing, merging, and validation. |
pkg/config/toml/config_test.go |
Tests multiplier validation and configuration merging. |
pkg/config/config.go |
Exposes the multiplier through the configuration interface. |
pkg/config/config_test.go |
Tests default and configured multiplier values. |
pkg/config/chain_scoped_transactions.go |
Implements the chain-scoped multiplier accessor. |
CONFIG.md |
Adds user-facing multiplier documentation. |
Review effort: Balanced
Comment on lines
+108
to
+109
| f, _ := t.c.FeeMultiplier.BigFloat().Float32() | ||
| return f |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.