Repository navigation
ci(package): fix the e2e test as a non-root runner user - #406
Merged
Merged
Conversation
The packaged config is root:homer 0640, so read it through sudo. Keep the HEP listener open until the SIP sender stops, so heplify does not log 'connection refused' for the resent copies (which failed the journal check). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NgFoiYq2FPKmcu9vc71Rtz
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Alex · project thread
The
e2ejob added in #404 failed on the runner. This only touches the test, not the packages:runneruser and could not read theroot:homer 0640config (PermissionError). It now reads the config throughsudo.connection refused, which would fail the journal check. The listener now stays open until the sender stops, and the sender stops once the packet has arrived.Checked as a non-root sudo user in an Ubuntu 24.04 systemd container: pass. This PR touches
scripts/, so the Package check workflow runs on it.(This commit was pushed to #405 just after that PR was merged, so it did not land.)
Generated by Claude Code