Repository navigation
Fix(CertUtils): Skip The Revocation Check When No CRL Or OCSP Source Is Available - #92
Open
misiektoja wants to merge 4 commits into
Open
misiektoja wants to merge 4 commits into
misiektoja wants to merge 4 commits into
Conversation
…is available and this is allowed
…tion status checks
…the Validate If Certificate Is Revoked docstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate If Certificate Is Revokednow returns with a log message whenallow_no_crl_urls=True, no URL or CRL file is passed, the certificate has no CRL distribution point and OCSP cannot be used, because the certificate has no OCSP URL or noca_certis given. Withoutallow_no_crl_urlsit still raises. The three accepted revocation and revive tests passallow_no_crl_urls=True. The keyword documentation describes the skip and its examples use the realca_certargument.Motivation and Context
RFC 9483 Section 4.3.4 says a CA "may include" CRL distribution points or AIA extensions. The tests failed after a correct rp because the follow-up check had no source to query.
How Has This Been Tested?
New unit tests cover a certificate without OCSP and CRL sources with and without
allow_no_crl_urlsand check that no request is sent. The case withallow_no_crl_urls=Truefails onmainand passes with this change. Other unit test results matchmain. Against the mock CA, which adds both sources, the revocation tests pass as onmain.robot --dryrun,robocop checkandcodespellpass. Python 3.15 with pytest 9.2 and Robot Framework 7.5.