Repository navigation
Fix(CmpUtils): Keep The RDN Order In The kur oldCertId Control - #87
Open
misiektoja wants to merge 2 commits into
Open
misiektoja wants to merge 2 commits into
misiektoja wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
prepare_old_cert_id_controlnow copies the issuerNamefrom the certificate. An issuer string passed by the caller is still parsed as before.Motivation and Context
The function converted the issuer to an OpenSSL-style string and back, the same round trip that #84 removes from the CertTemplate code. A multi-RDN issuer came back reversed, so oldCertId identified no certificate (RFC 9483 Section 4.1.3).
How Has This Been Tested?
A new unit test compares the issuer DER for a multi-RDN certificate. It fails on
mainand passes with this change. A second test checks that changing the control does not change the certificate. It passes on both. Other unit test results matchmain. Python 3.15 with pytest 9.2.