Repository navigation
Fix(Asn1Utils): Make is_bit_set Independent Of The Order Of The Names - #116
Open
misiektoja wants to merge 2 commits into
Open
misiektoja wants to merge 2 commits into
misiektoja wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
is_bit_setnow compares the set bit names with the given names as sets, so the order of the names no longer matters. The docstring and every other result stay the same.Motivation and Context
With
exclusive=Trueand all listed bits set, the result depended on the order:badRequest,badDataFormatpassed andbadDataFormat,badRequestfailed. Four calls intests/list their bits out of bit order, for exampletransactionIdInUse,badRequest. Follow-up to the discussion in #107.How Has This Been Tested?
A new unit test checks both orders with and without
exclusive. It fails onmainand passes with this change. A second test checks that names that differ from the set bits still fail withexclusive=Truein either order. Other unit test results matchmain. Python 3.15 with pytest 9.2.