Repository navigation
Fix(CheckUtils): Fail The MAC Sender Checks When The Sender Has No commonName - #115
Open
misiektoja wants to merge 3 commits into
Open
misiektoja wants to merge 3 commits into
misiektoja wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_verify_sender_field_for_macand_verify_senderkid_for_macnow read the commonName from the dictionary form of the lookup.Motivation and Context
Both functions look up the commonName with
get_openssl_name_notation._verify_sender_field_for_macthen fails only if the result isNoneand_verify_senderkid_for_maconly if it is empty. Without a commonName the lookup returns the string "NULL-DN", so neither check fires. RFC 9483 Section 3.1 requires the commonName for MAC protection. Withallow_failure=Falsea MAC-protected message without it passedCheck Sender CMP Protection.Validate senderKID For CMP Protectionaccepted the senderKID "NULL-DN". The mock CA runs both checks on every request, so it now rejects such a request.How Has This Been Tested?
New unit tests send a MAC-protected message whose sender has no commonName to
Check Sender CMP ProtectionandValidate senderKID For CMP Protection. They fail onmainand pass with this change. Other unit test results matchmain. Python 3.15 with pytest 9.2.