Repository navigation
Fix(Tests): Pass The Revocation Certificate As senderKID In The Issuer-As-Sender Test - #114
Open
misiektoja wants to merge 1 commit into
Open
misiektoja wants to merge 1 commit into
misiektoja wants to merge 1 commit into
Conversation
…er-as-sender rr test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
"CA MUST Reject Revocation Request With Issuer As Sender" now passes
sender_kid=${REVOCATION_CERT}toPatch SenderKID, which sets the SubjectKeyIdentifier of the certificate.Motivation and Context
The test passed
cert=${REVOCATION_CERT}.certis not an argument of the keyword, so Robot sent the text "cert=..." as the senderKID. The CA could then reject the request because the senderKID does not identify the protection key (RFC 9483 Section 3.5), not because the sender is the issuer.How Has This Been Tested?
Checked offline that the old call sets the senderKID to the literal text and the new call sets the SKI.
robot --dryrun,robocop checkandcodespellpass. Python 3.15 with Robot Framework 7.5.