Repository navigation
Conversation
Kallyan01
force-pushed
the
test/vitest-qa-coverage
branch
from
October 29, 2026 19:59
fe558b0 to
679764b
Compare
Kallyan01
force-pushed
the
test/vitest-qa-coverage
branch
from
October 29, 2026 20:17
679764b to
51670ea
Compare
Kallyan01
marked this pull request as ready for review
October 29, 2026 20:32
justlevine
force-pushed
the
fix/brand-site-connection
branch
from
October 31, 2026 17:12
bad6fb5 to
d43e0c1
Compare
Kallyan01
force-pushed
the
test/vitest-qa-coverage
branch
from
November 6, 2026 20:42
51670ea to
cec877a
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues require resolution for this test-only expansion of settings and template-library regression coverage.
No open issues 🎉
What changed in this PR
This test-only PR expands JavaScript regression coverage for OneDesign’s settings and template library, covering additional QA scenarios without changing production code.
Changes:
- Add validation tests for missing fields, whitespace-only inputs, and invalid site URLs.
- Cover site-type selection and saving, disconnect availability, and notification timing.
- Verify template search, selection counts, apply-button availability, and removal cancellation.
| File | Description |
|---|---|
tests/js/template-library.test.tsx |
Tests search, selection counts, apply availability, and cancellation without deletion. |
tests/js/SiteTypeSettings.test.tsx |
Tests selection requirements and saving both site types. |
tests/js/SiteSettings.test.tsx |
Checks that disconnect is disabled before a governing site connects. |
tests/js/SiteModal.test.tsx |
Tests invalid URLs, missing fields, and whitespace-only inputs. |
tests/js/SettingsPage.test.tsx |
Tests snackbar timeout behavior and persistent warning notices. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Expand JavaScript regression coverage for settings, site validation, and the template library.
Why
Cover additional QA scenarios and edge cases, including invalid inputs, unavailable actions, notification timing, and cancellation behavior.
Related Issue(s):
How
AI Disclosure
AI assisted with reviewing the changes and drafting this PR description.
Testing Instructions
Screenshots
Additional Info
Checklist