Skip to content

test(js): covers testcases from qa sheet - #199

Open
Kallyan01 wants to merge 1 commit into
mainfrom
test/vitest-qa-coverage
Open

Kallyan01 wants to merge 1 commit into
mainfrom
test/vitest-qa-coverage

Conversation

@Kallyan01

@Kallyan01 Kallyan01 commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

What

Expand JavaScript regression coverage for settings, site validation, and the template library.

Why

Cover additional QA scenarios and edge cases, including invalid inputs, unavailable actions, notification timing, and cancellation behavior.

Related Issue(s):

How

  • Test missing fields, whitespace-only inputs, and invalid site URLs.
  • Verify site type selection and saving for both site types.
  • Check disconnect availability, snackbar timing, and persistent notices.
  • Test template search, selection counts, apply availability, and cancelling removal.

AI Disclosure

AI assisted with reviewing the changes and drafting this PR description.

Testing Instructions

Screenshots

Additional Info

Checklist

  • I have read the Contribution Guidelines.
  • I have read the Development Guidelines.
  • I have added necessary tests to cover my changes.
  • I have updated the project documentation as needed.
  • My code has detailed inline documentation.
  • My code is tested to the best of my abilities.
  • My code passes all lints, tests, and checks.
Open WordPress Playground Preview

@Kallyan01
Kallyan01 force-pushed the test/vitest-qa-coverage branch from fe558b0 to 679764b Compare October 29, 2026 19:59
@Kallyan01
Kallyan01 changed the base branch from main to fix/brand-site-connection October 29, 2026 20:02
@Kallyan01
Kallyan01 force-pushed the test/vitest-qa-coverage branch from 679764b to 51670ea Compare October 29, 2026 20:17
@Kallyan01
Kallyan01 requested a review from justlevine October 29, 2026 20:32
@Kallyan01
Kallyan01 marked this pull request as ready for review October 29, 2026 20:32
@Kallyan01 Kallyan01 self-assigned this Oct 30, 2026
@justlevine
justlevine force-pushed the fix/brand-site-connection branch from bad6fb5 to d43e0c1 Compare October 31, 2026 17:12
Base automatically changed from fix/brand-site-connection to main November 4, 2026 21:43
@Kallyan01
Kallyan01 force-pushed the test/vitest-qa-coverage branch from 51670ea to cec877a Compare November 6, 2026 20:42
Copilot AI balanced review requested due to automatic review settings November 6, 2026 20:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues require resolution for this test-only expansion of settings and template-library regression coverage.

No open issues 🎉

What changed in this PR

This test-only PR expands JavaScript regression coverage for OneDesign’s settings and template library, covering additional QA scenarios without changing production code.

Changes:

  • Add validation tests for missing fields, whitespace-only inputs, and invalid site URLs.
  • Cover site-type selection and saving, disconnect availability, and notification timing.
  • Verify template search, selection counts, apply-button availability, and removal cancellation.
File Description
tests/​js/​template-library.test.tsx Tests search, selection counts, apply availability, and cancellation without deletion.
tests/​js/​SiteTypeSettings.test.tsx Tests selection requirements and saving both site types.
tests/​js/​SiteSettings.test.tsx Checks that disconnect is disabled before a governing site connects.
tests/​js/​SiteModal.test.tsx Tests invalid URLs, missing fields, and whitespace-only inputs.
tests/​js/​SettingsPage.test.tsx Tests snackbar timeout behavior and persistent warning notices.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants