Repository navigation
fix: don't fire UserLoginEvent for players without a User (fake players) - #1627
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1398
Problem
Plugins that spawn fake players via
PlayerList#placeNewPlayer(e.g. Asteroid) cause Bukkit to fire a normalPlayerJoinEvent.InternalGlobalBukkitListener#onPlayerJointhen resolves theUserwithPlayerManager#getUser, which returnsnullfor these players since they were never injected into a channel,and fires
UserLoginEventwith that null user anyway.Listeners that expect a valid
User(e.g. KnockbackSync) then fail with a NullPointerException.Change
Skip firing
UserLoginEventwhen noUserexists for the joining player.Notes
Real players are unaffected, since they always have a
Useronce their channel is injected.