You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor: [headline, container] use start and end for align - #974
Rename align values on Headline and Container from left, center, right to start, center, end. This is a breaking change. Headline defaults to start, and Container still defaults to center.
Use logical margins (margin-inline) for Container alignment, so start and end follow the text direction. Headline already used text-align: start and end.
Rename the CSS module classes to align-start, align-center and align-end.
Update the docs pages, playgrounds, props tables and tests, and add an "align takes start and end" section to the upgrading page.
Decisions:
center is also renamed to align-center, so the three classes follow the <prop>-<value> rule.
left and right are removed with no deprecated alias.
In left-to-right layouts, pixels and defaults do not change.
Visual check: I compared the docs from this branch with a docs dev server built from main, in light and dark themes.
Headline and Container align demos: in LTR, start, center and end have the same computed margins, text alignment and positions as left, center and right on main. With dir="rtl" on the demo, Container start moves to the right edge. On main, left stays on the left.
Playgrounds: the align options are start, center and end. Both components render the selected value. The Headline code leaves out align when it is start.
The 404 page (two default Headlines) is the same as on main. The upgrading page section renders. No page errors.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Walkthrough
Container and Headline replace left and right alignment values with start and end, while retaining center. The components use updated alignment classes, and Container uses logical inline margins. Headline now defaults to start; Container retains its center default. Tests, playground examples, component documentation, and the upgrading guide reflect the new values and text-direction behavior.
Suggested reviewers:shreyag02
Priority: ➖ Normal
Merge Risk:⚪ Minimal · up to 7744d
The alignment rename is documented as a breaking change, and no broken in-repository caller or other actionable merge risk was identified. The PR is mergeable subject to normal checks.
Pre-merge checks: 5
Check name
Status
Explanation
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 8…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Title check
The title clearly summarizes the main change: Headline and Container now use start and end alignment values.
Description check
The description directly explains the alignment rename, breaking-change behavior, logical CSS updates, documentation changes, and validation performed.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 8 files. (5 skipped: 5 unsupported.)
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alignvalues onHeadlineandContainerfromleft,center,righttostart,center,end. This is a breaking change.Headlinedefaults tostart, andContainerstill defaults tocenter.margin-inline) forContaineralignment, sostartandendfollow the text direction.Headlinealready usedtext-align: startandend.align-start,align-centerandalign-end.aligntakesstartandend" section to the upgrading page.Decisions:
centeris also renamed toalign-center, so the three classes follow the<prop>-<value>rule.leftandrightare removed with no deprecated alias.Visual check: I compared the docs from this branch with a docs dev server built from
main, in light and dark themes.Headline and Container align demos: in LTR,
start,centerandendhave the same computed margins, text alignment and positions asleft,centerandrightonmain. Withdir="rtl"on the demo, Containerstartmoves to the right edge. Onmain,leftstays on the left.Playgrounds: the align options are
start,centerandend. Both components render the selected value. The Headline code leaves outalignwhen it isstart.The 404 page (two default Headlines) is the same as on
main. The upgrading page section renders. No page errors.I have followed the pull request section of the contributing guide.