Repository navigation
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24107
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unclassified FailureAs of commit dedcd5f with merge base 2c3e231 ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 23, 2026
This PR needs a
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
forward_othersandforward_from_embeddingstake up tomax_step_tokens(4096) tokens and select which rows' logits to return. The selector's dynamic
bound was also
max_step_tokens, so memory planning sized each method's FP32logits output at
4096 x 202048 x 4 B = 3157 MiB, allocated at load whether ornot a request ever uses it.
A step never selects more rows than the device samplers take
(
MAX_SAMPLE_ROWS = 64: one row per prefilling session, ormax_owners x blockfor DFlash verify), and the executor already rejects a step with more.Bound the selector at
min(max_step_tokens, MAX_SAMPLE_ROWS). Each plannedlogits output drops to 49 MiB; token width and the DFlash taps keep their
max_step_tokensbound.Differential Revision: D127114350