Skip to content

Skip the batch sampler runtime test on ROCm - #24013

Merged
meta-codesync[bot] merged 1 commit into
mainfrom
export-D126231386
Oct 20, 2026
Merged

meta-codesync[bot] merged 1 commit into
mainfrom
export-D126231386

Conversation

@Gasoonjia

Copy link
Copy Markdown
Contributor

Summary:
The ROCm AOTI unittest job on main fails during pytest collection: the newly added batch sampler test imports the Python runtime at module scope, and the ROCm CI build only ships executor_runner, not the pybindings extension. One collection error aborts the whole backends/cuda/tests run, so every ROCm test stops running.

Import the runtime inside the test and skip the class on ROCm, following the existing convention for tests that load through the Python runtime.

Differential Revision: D126231386

Summary:
The ROCm AOTI unittest job on main fails during pytest collection: the newly added batch sampler test imports the Python runtime at module scope, and the ROCm CI build only ships executor_runner, not the pybindings extension. One collection error aborts the whole backends/cuda/tests run, so every ROCm test stops running.

Import the runtime inside the test and skip the class on ROCm, following the existing convention for tests that load through the Python runtime.

Differential Revision: D126231386
@pytorch-bot

pytorch-bot Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24013

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 37 Pending, 2 Unrelated Failures

As of commit 901fab9 with merge base b1beef3 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 20, 2026
@meta-codesync

meta-codesync Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

@Gasoonjia has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126231386.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync
meta-codesync Bot merged commit c4c10ca into main Oct 20, 2026
285 of 307 checks passed
@meta-codesync
meta-codesync Bot deleted the export-D126231386 branch October 20, 2026 06:41

This branch was successfully deployed

1 active deployment
cadence — 901fab9b Deployed Oct 20, 2026 by Gasoonjia via hifi-op-test / hifi4 #34156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/rocm CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: rocm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants