[wopsononock]

No description provided.

[bozana]

Hi @wopsononock, thanks for the 3.3 maintenance release!

We now use Claude to review the plugins, and here is what it found (I've gone through the points):

Before we merge this, these two points need addressing:

1. templates/blockReferences.tpl:18: {foreach from=parsedCitations …} is missing its $, so whenever the References block is placed and an article has references, the article page fails with a PHP error. (1.4.x already has it right.)

2. The inline page shows the HTML full text on the article landing page without OJS's access check (hasAccess, and "Restrict article access to registered users"). OJS checks access only when a galley is opened, so with the plugin on, signed-out visitors read the full text of subscription, purchase-only or registered-only articles at article/view/<id>. On open-access journals this changes nothing. Please either:

   • state in the README that the plugin is meant for open-access journals without restricted access, or
   • fall back to OJS's normal landing page (return false) unless $templateMgr->getTemplateVars('hasAccess') is true and, when the journal's restrictArticleAccess setting is on, a user is signed in. This has no effect on open-access journals.

   The same applies to 1.4.x for OJS 3.5.

These are worth fixing too, now or in a later release:

• Older-version pages (article/view/<id>/version/<publicationId>) show the current version's galley, title and abstract. Use the publication the hook passes as $args[3]. (Also in 1.4.x.)
• loadHTML() with no encoding garbles accented text in UTF-8 galleys that don't declare a charset. Prefix <?xml encoding="UTF-8">. (Also in 1.4.x.)
• An empty galley file (PHP 8 throws ValueError, which catch (Exception) doesn't catch) or a file missing from disk gives a server error instead of a page. Fall back to OJS's landing page, and catch Throwable. (Also in 1.4.x.)
• Under Bootstrap3 the plugin replaces five of the theme's templates (header, headerHead, footer, navigationMenu, searchForm_simple) on every public page, not only on article pages, with copies from 2017–2019. Later Bootstrap3 fixes to those templates are therefore missing while the plugin is on. You could drop the overrides, as 1.4.x has done, or at least mention them in the README.
• Smaller things, all already fixed in 1.4.x: the Authors/Licence blocks use plugins.themes.classic.* keys (readers see ##…##), the cover-image block calls a method on a missing issue, the keywords block lists every language, and two values are printed without |escape: citationsRaw in templates/blockReferences.tpl:24 and the ORCID in the href in templates/blockAuthors.tpl:24. Also, the first HTML galley is shown in every language, and settings.xml is still named through the inherited getContextSpecificPluginSettingsFile() (return null).

Thanks!