Repository navigation
Update transferList type in emit method signature - #233
Conversation
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
can you add a test for this type?
@mcollina I've tried this locally but the type test would only work if we bump @types/node to "^26". Since TransferListItem and Transferable are "equal types", no test feature that I know of could verify this deprecation in @types/node@25. Is that ok to add as well? |
|
that's ok |
|
This looks like a good patch! @verheyenkoen planning on rebasing? want a hand? |
b2b75ff to
2b67a6a
Compare
@types/node 26 renamed worker_threads.TransferListItem to Transferable, and thread-stream (via pino) still uses the old name in its typings, so every package that imports pino failed to typecheck. Carry the one-line upstream fix (pinojs/thread-stream#233) as a pnpm patch until it ships; pnpm will refuse to apply it once thread-stream moves past 4.2.0. 26.4.1 rather than 26.5.x because of the three-day minimumReleaseAge.
|
Just as an FYI, I think this one is about to blow up: as of tomorrow, node 26 becomes the new LTS. |
|
It has blown up, any chance we could get this merged pls? |
|
FIXES #228