Repository navigation
fix(shared): @ mentions complete display names in any script #36504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
juliusmarminge
merged 3 commits into
pingdotgg:main
from
JS-coder-K:pr/mention-any-script
Nov 14, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normalize display-name and login comparisons before matching.
The
@trigger now accepts combining marks, but the author completion path compares the raw query withloginandnamewithout normalization. A decomposed query such asJose\u0301therefore does not match a display name stored in composed form, such asJosé. The same mismatch occurs in the server rank and in the client narrowing. Logins that are ASCII still match.Normalize both the query and the compared text to NFC in both locations. The server change is needed so that matching names are returned, and the client change is needed so that they are not dropped afterward.
Suggested fix
export function narrowPullRequestMentions<A extends { login: string; name: string | null }>( users: ReadonlyArray<A>, typed: string, limit: number, ): A[] { - const needle = typed.toLowerCase(); + const needle = typed.normalize("NFC").toLowerCase(); return users .filter( (user) => - user.login.toLowerCase().includes(needle) || - (user.name?.toLowerCase().includes(needle) ?? false), + user.login.normalize("NFC").toLowerCase().includes(needle) || + (user.name?.normalize("NFC").toLowerCase().includes(needle) ?? false), ) .slice(0, limit); }There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this out of this PR. The composed/decomposed mismatch already exists for
#references, because the server ranking inPullRequestServiceis shared by labels, references and authors. That makes it a separate fix rather than part of letting non-ASCII names open the list. Keyboard IMEs (Korean, Japanese, Devanagari and others) produce composed text, so the gap mostly affects pasted NFD text. Happy to send it as its own PR if maintainers want it.