Repository navigation
fix: recover after a failed Playwright initialize - #275
Merged
MrPunyapal merged 8 commits intoOct 29, 2026
Merged
Conversation
Playwright marks a connection initialized before the browser finishes launching, and it accepts that call only once. Give the launch its own timeout, and drop the socket when initialize fails so the next test can connect again.
|
We hit this on GitHub Actions ( We reproduced it locally by stopping the Chrome process that the Playwright server starts ( |
Keep both the closed-connection exception and disconnect() so a failed initialize can open a new socket.
MrPunyapal
approved these changes
Oct 29, 2026
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes pestphp/pest#1938.
Playwright accepts
initializeonce per WebSocket and sets that flag before the browser launch finishes. If the launch hits the action timeout,$browserTypesstays empty, so the next browser test sendsinitializeagain and every later test fails withAssertion error.initializecloses the socket. The next browser test connects again and can initialize.Test plan
tests/Browser/Visit/InitializeRecoveryTest.phpforces a secondinitializeon the same connection, expectsAssertion error, then opens a page on a new connection