Repository navigation
Conversation
smaugho
force-pushed
the
fix/pnpm-workspace-install
branch
from
November 5, 2026 18:52
520625d to
cf8a6ff
Compare
smaugho
force-pushed
the
fix/pnpm-workspace-install
branch
from
November 6, 2026 21:06
cf8a6ff to
b2e4dbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23752.
Problem
In a pnpm workspace, installing the node package for a target only installed that package's own dependencies. When the package depends on another workspace package, that package's dependencies were left uninstalled, so code importing through it failed at runtime (e.g.
Cannot find package '@invented/leaf').Change
When Pants installs a pnpm workspace member, it now selects the member together with its dependencies, using pnpm's
<package>...filter, instead of the member alone.docs/notes/2.34.x.md.Tests
reader -> contract -> leaf. It installs through the real rules and runs Node. On current main without the fix it fails (Cannot find package '@invented/leaf'); with the fix Node prints42.install_node_package_test.pyandnodejs_project_environment_test.py, lint, MyPy,build-support/githooks/pre-pushandpants --changed-since=HEAD fmtall pass.AI disclosure
This PR was written primarily by Claude Code; I reviewed and tested it.