Skip to content

Proxy: Reclaim closed and idle WebRTC sessions #4795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xhy279 wants to merge 1 commit into
base: develop
Choose a base branch
from
+563 −42
Open

Proxy: Reclaim closed and idle WebRTC sessions #4795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/lb/mem.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,3 +169,10 @@ func (v *memoryLoadBalancer) LoadWebRTCByUfrag(ctx context.Context, ufrag string
return actual, nil
}
}

// DeleteWebRTC removes only this session, preserving a newer stream mapping.
func (v *memoryLoadBalancer) DeleteWebRTC(ctx context.Context, streamURL string, value RTCConnection) error {
v.rtcStreamURL.CompareAndDelete(streamURL, value)
v.rtcUfrag.CompareAndDelete(value.GetUfrag(), value)
return nil
}
19 changes: 19 additions & 0 deletions internal/lb/mem_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,3 +284,22 @@ func TestMemLB_LoadWebRTCByUfrag_NotFound(t *testing.T) {
t.Fatalf("expected error, got %v", err)
}
}

func TestMemLB_DeleteWebRTCPreservesReplacement(t *testing.T) {
b := newMem()
ctx := context.Background()
old := &stubRTC{ufrag: "old"}
fresh := &stubRTC{ufrag: "new"}
_ = b.StoreWebRTC(ctx, "shared", old)
_ = b.StoreWebRTC(ctx, "shared", fresh)
_ = b.DeleteWebRTC(ctx, "shared", old)
if _, err := b.LoadWebRTCByUfrag(ctx, "old"); err == nil {
t.Fatal("old session retained")
}
if got, err := b.LoadWebRTCByUfrag(ctx, "new"); err != nil || got != fresh {
t.Fatal("new session removed")
}
if got, ok := b.rtcStreamURL.Load("shared"); !ok || got != fresh {
t.Fatal("new stream mapping removed")
}
}
Loading
Loading